>>>>> "Freddie" == Freddie Chopin <[email protected]> writes:
...
Freddie> At the beginning please let me state, that I'm not an active
Freddie> maintainer - I probably merged some things recently, but this
Freddie> cannot be compared with the work of other maintainers.
No offence intended to you or any of the mantainers. Are there any explicit
mantainers?
Or are there only some people with git write allowance?
Freddie> There's no policy, at least I'm not aware of any... I probably
Freddie> still have permissions to merge patches from gerrit, but I'm a
Freddie> little bit afraid that I could merge something that would break
Freddie> other things... With software like OpenOCD it is not possible
Freddie> to verify every change "in reality" - no person has all the
Freddie> hardware or all the setups needed to do that. Additionally no
Freddie> one has time needed to study the technical docs to verify that
Freddie> the change is correct. That's why I think (this is a personal
Freddie> opinion) a test report is worth much more than a code review.
This is what I wanted to explain in my other mail. So I follow your personal
opinion.
Freddie> I've looked at the 2868 change - at the actual diff - but I
Freddie> cannot tell whether the code is correct or not. I could merge
Freddie> it right away, but I'm not entirely confident to do it...
The patch evolved from some other approach Remi used. It tries to follow
what as I understand the ARM manuals. Maybe I should have added an explicit
reference. I works for me (TM) :-) as the second step of patch evolution:
- It should work
- It works for me
- Others can reproduce the working
Freddie> As for the 2336 change - from what I see it has been approved
Freddie> in February and merged on 9th of March... Maybe you had some
Freddie> other change in you mind?
Maybe I saw ghosts, but this morning I still saw it on the "open" webpage...
Thanks for the feedback
--
Uwe Bonnes [email protected]
Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt
--------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------
Ab 1.11.2015 Neue Rufnummern! New phone number starting Nov. 1. 2015!
--------- Tel. 06151 1623569 ------- Fax. 06151 1623305 ---------
------------------------------------------------------------------------------
_______________________________________________
OpenOCD-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openocd-devel
