This is an automated email from Gerrit. Alamy Liu ([email protected]) just uploaded a new patch set to Gerrit, which you can find at http://openocd.zylin.com/3335
-- gerrit commit 720dc31849d7db3710cc5c8fbb4b2fe4e05753f0 Author: Alamy Liu <[email protected]> Date: Tue Dec 1 11:37:54 2015 -0800 aarch64: Use ARMv8 nameing (i.e.: dscr->edscr; INSTR_COMP->ITE) Reason ARMv8 document has different naming from v7. Change-Id: I52474d872acac463140c42dc73f73bb30360e27f Signed-off-by: Alamy Liu <[email protected]> diff --git a/src/target/aarch64.c b/src/target/aarch64.c index 7062e71..2cc9127 100644 --- a/src/target/aarch64.c +++ b/src/target/aarch64.c @@ -573,22 +573,27 @@ static int aarch64_instr_read_data_dcc(struct arm_dpm *dpm, return aarch64_read_dcc(a8, data, &dscr); } +/* + * Called by + * dpm_read_reg_aarch64(), directly, to read registers. i.e.: AARCH64_X0 ... AARCH64_X30 + * dpm_read_reg_aarch64(), through aarch64_instr_read_data_x0(), to read special registers. + */ static int aarch64_instr_read_data_dcc_64(struct arm_dpm *dpm, uint32_t opcode, uint64_t *data) { struct aarch64_common *a8 = dpm_to_a8(dpm); int retval; - uint32_t dscr = DSCR_INSTR_COMP; + uint32_t edscr; - /* the opcode, writing data to DCC */ - retval = aarch64_exec_opcode( - a8->armv8_common.arm.target, - opcode, - &dscr); + /* We are sure that ITR is empty & DCC RX is empty after dpm_prepare() + * edscr still got updated after opcode is executed + */ + edscr = ARMV8_EDSCR_ITE; + retval = aarch64_exec_opcode(dpm->arm->target, opcode, &edscr); if (retval != ERROR_OK) return retval; - return aarch64_read_dcc_64(a8, data, &dscr); + return aarch64_read_dcc_64(a8, data, &edscr); } static int aarch64_instr_read_data_r0(struct arm_dpm *dpm, -- ------------------------------------------------------------------------------ Site24x7 APM Insight: Get Deep Visibility into Application Performance APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month Monitor end-to-end web transactions and take corrective actions now Troubleshoot faster and improve end-user experience. Signup Now! http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140 _______________________________________________ OpenOCD-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openocd-devel
