This is an automated email from Gerrit. Alamy Liu ([email protected]) just uploaded a new patch set to Gerrit, which you can find at http://openocd.zylin.com/3314
-- gerrit commit 4b4b9efb71d3e4827fbc3acdaeb30c88d59a7ee6 Author: Alamy Liu <[email protected]> Date: Wed Oct 14 09:27:23 2015 -0700 Alamy comments Change-Id: I2d5be236b9997d2c744bdce1cdda1d302906d807 Signed-off-by: Alamy Liu <[email protected]> diff --git a/src/target/armv8.h b/src/target/armv8.h index 89929a4..ccd11b4 100644 --- a/src/target/armv8.h +++ b/src/target/armv8.h @@ -535,6 +535,7 @@ struct armv8_common { struct armv8_mmu_common armv8_mmu; /* Direct processor core register read and writes */ + /* Alamy(2015-1009): I found that there is no use of these functions in ARMv8 */ int (*load_core_reg_u64)(struct target *target, uint32_t num, uint64_t *value); int (*store_core_reg_u64)(struct target *target, uint32_t num, uint64_t value); diff --git a/src/target/target.c b/src/target/target.c index 1d0653d..bcaa1e2 100644 --- a/src/target/target.c +++ b/src/target/target.c @@ -2687,6 +2687,10 @@ COMMAND_HANDLER(handle_reg_command) if ((CMD_ARGC == 2) && (strcmp(CMD_ARGV[1], "force") == 0)) reg->valid = 0; + /* Might never happen: + * When halted, register value is valid (except modified later) + * When not halted, the function (i.e.: armv8_get_core_reg) won't read register + */ if (reg->valid == 0) reg->type->get(reg); handle_reg_display_one_register(CMD_CTX, reg); -- ------------------------------------------------------------------------------ Site24x7 APM Insight: Get Deep Visibility into Application Performance APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month Monitor end-to-end web transactions and take corrective actions now Troubleshoot faster and improve end-user experience. Signup Now! http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140 _______________________________________________ OpenOCD-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openocd-devel
