This is an automated email from Gerrit.

Anonymous Coward ([email protected]) just uploaded a new patch set to Gerrit, 
which you can find at http://openocd.zylin.com/3363

-- gerrit

commit 503c8274d0e587fd90d372c0163ba689f85baff9
Author: Alexander Kurz <[email protected]>
Date:   Fri Feb 26 21:54:22 2016 +0100

    arm_disassembler: bugfix, MRRC instruction not recognized
    
    A copy-and-paste error in the arm_disassembler opcode evaluation
    disabled the recognition of MRRC instructions.
    Error found by static code analysis using a semantic pattern to
    detect duplicated tests xand.cocci, see coccinellery.org
    
    Change-Id: Ic41426edb51c6816e11dc3d35ef9382ab34af486
    Signed-off-by: Alexander Kurz <[email protected]>

diff --git a/src/target/arm_disassembler.c b/src/target/arm_disassembler.c
index 65086c2..5cec6d6 100644
--- a/src/target/arm_disassembler.c
+++ b/src/target/arm_disassembler.c
@@ -278,7 +278,7 @@ static int evaluate_ldc_stc_mcrr_mrrc(uint32_t opcode,
        uint8_t cp_num = (opcode & 0xf00) >> 8;
 
        /* MCRR or MRRC */
-       if (((opcode & 0x0ff00000) == 0x0c400000) || ((opcode & 0x0ff00000) == 
0x0c400000)) {
+       if (((opcode & 0x0ff00000) == 0x0c400000) || ((opcode & 0x0ff00000) == 
0x0c500000)) {
                uint8_t cp_opcode, Rd, Rn, CRm;
                char *mnemonic;
 

-- 

------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140
_______________________________________________
OpenOCD-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openocd-devel

Reply via email to