This is an automated email from Gerrit.

Paul Fertser ([email protected]) just uploaded a new patch set to Gerrit, 
which you can find at http://openocd.zylin.com/3933

-- gerrit

commit 4335126c610f1670317df0f477ac6c5996793e41
Author: Paul Fertser <[email protected]>
Date:   Sat Dec 31 21:01:52 2016 +0300

    jtag: drivers: sysfsgpio, bcm2835gpio: remove requirement to have trst or 
srst
    
    This doesn't seem to make any sense.
    
    Change-Id: I272de0ea3c0e86cc9a798cbd864050aaa597c3f0
    Signed-off-by: Paul Fertser <[email protected]>

diff --git a/src/jtag/drivers/bcm2835gpio.c b/src/jtag/drivers/bcm2835gpio.c
index a41caf0..a4d0a1c 100644
--- a/src/jtag/drivers/bcm2835gpio.c
+++ b/src/jtag/drivers/bcm2835gpio.c
@@ -432,10 +432,6 @@ static int bcm2835gpio_init(void)
                        LOG_INFO("JTAG and SWD modes enabled");
                else
                        LOG_INFO("JTAG only mode enabled (specify swclk and 
swdio gpio to add SWD mode)");
-               if (!is_gpio_valid(trst_gpio) && !is_gpio_valid(srst_gpio)) {
-                       LOG_ERROR("Require at least one of trst or srst gpios 
to be specified");
-                       return ERROR_JTAG_INIT_FAILED;
-               }
        } else if (bcm2835gpio_swd_mode_possible()) {
                LOG_INFO("SWD only mode enabled (specify tck, tms, tdi and tdo 
gpios to add JTAG mode)");
        } else {
diff --git a/src/jtag/drivers/sysfsgpio.c b/src/jtag/drivers/sysfsgpio.c
index 77b727c..b8acfa2 100644
--- a/src/jtag/drivers/sysfsgpio.c
+++ b/src/jtag/drivers/sysfsgpio.c
@@ -592,10 +592,6 @@ static int sysfsgpio_init(void)
                        LOG_INFO("JTAG and SWD modes enabled");
                else
                        LOG_INFO("JTAG only mode enabled (specify swclk and 
swdio gpio to add SWD mode)");
-               if (!is_gpio_valid(trst_gpio) && !is_gpio_valid(srst_gpio)) {
-                       LOG_ERROR("Require at least one of trst or srst gpios 
to be specified");
-                       return ERROR_JTAG_INIT_FAILED;
-               }
        } else if (sysfsgpio_swd_mode_possible()) {
                LOG_INFO("SWD only mode enabled (specify tck, tms, tdi and tdo 
gpios to add JTAG mode)");
        } else {

-- 

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most 
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
OpenOCD-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openocd-devel

Reply via email to