This is an automated email from Gerrit. Tomas Vanek ([email protected]) just uploaded a new patch set to Gerrit, which you can find at http://openocd.zylin.com/3945
-- gerrit commit 4ee2b28624a95facfadad908e84c2293f17444f1 Author: Tomas Vanek <[email protected]> Date: Mon Jan 9 17:06:52 2017 +0100 jtag/drivers cmsis-dap: do not limit speed so strictly Adapter clock frequency is set by 32-bit number and most adapters limit the highest speed safely. There is no reason to impose strict limit of 5000 kHz if some adapters can do more. While on it handle 'adapter_khz 0' as no speed setting. Most adapters use a reasonable default then. More informative message is presented to user. Change-Id: I45c9804678e24496ea769ea9ca6036701b04dde9 Signed-off-by: Tomas Vanek <[email protected]> diff --git a/src/jtag/drivers/cmsis_dap_usb.c b/src/jtag/drivers/cmsis_dap_usb.c index cffd5e7..09b7bef 100644 --- a/src/jtag/drivers/cmsis_dap_usb.c +++ b/src/jtag/drivers/cmsis_dap_usb.c @@ -407,6 +407,9 @@ static int cmsis_dap_cmd_DAP_SWJ_Clock(uint32_t swj_clock) int retval; uint8_t *buffer = cmsis_dap_handle->packet_buffer; + if (swj_clock == 0) + return ERROR_OK; /* use adapter default / last set clock */ + /* set clock in Hz */ swj_clock *= 1000; buffer[0] = 0; /* report number */ @@ -1499,15 +1502,11 @@ static int cmsis_dap_execute_queue(void) static int cmsis_dap_speed(int speed) { - if (speed > DAP_MAX_CLOCK) { - LOG_INFO("reduce speed request: %dkHz to %dkHz maximum", speed, DAP_MAX_CLOCK); - speed = DAP_MAX_CLOCK; - } + if (speed > DAP_MAX_CLOCK) + LOG_INFO("High speed (adapter_khz %d) may be limited by adapter firmware.", speed); - if (speed == 0) { - LOG_INFO("RTCK not supported"); - return ERROR_JTAG_NOT_IMPLEMENTED; - } + if (speed == 0) + LOG_WARNING("RTCK not supported. Set adapter_khz or adapter uses its default."); return cmsis_dap_cmd_DAP_SWJ_Clock(speed); } -- ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot _______________________________________________ OpenOCD-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openocd-devel
