This is an automated email from Gerrit. Matthias Welwarsky ([email protected]) just uploaded a new patch set to Gerrit, which you can find at http://openocd.zylin.com/3987
-- gerrit commit 7a6270e940c3001dbe022e7272515935d007aa01 Author: Matthias Welwarsky <[email protected]> Date: Sun Nov 27 11:28:01 2016 +0100 aarch64: remove bogus address check before memory access Mmu faults can not be prevented on aarch64, they need to be taken and handled accordingly. Remove the remaining stub code. Change-Id: I6241efa594fe6b963624f9628cdf1c8e46588223 Signed-off-by: Matthias Welwarsky <[email protected]> diff --git a/src/target/aarch64.c b/src/target/aarch64.c index d3ed57c..5dd6d7a 100644 --- a/src/target/aarch64.c +++ b/src/target/aarch64.c @@ -103,13 +103,6 @@ static int aarch64_restore_system_control_reg(struct target *target) return retval; } -/* check address before aarch64_apb read write access with mmu on - * remove apb predictible data abort */ -static int aarch64_check_address(struct target *target, uint32_t address) -{ - /* TODO */ - return ERROR_OK; -} /* modify system_control_reg in order to enable or disable mmu for : * - virt2phys address conversion * - read or write memory in phys or virt address */ @@ -1651,9 +1644,6 @@ static int aarch64_read_memory(struct target *target, target_addr_t address, return retval; if (mmu_enabled) { - retval = aarch64_check_address(target, address); - if (retval != ERROR_OK) - return retval; /* enable MMU as we could have disabled it for phys access */ retval = aarch64_mmu_modify(target, 1); if (retval != ERROR_OK) @@ -1691,9 +1681,6 @@ static int aarch64_write_memory(struct target *target, target_addr_t address, return retval; if (mmu_enabled) { - retval = aarch64_check_address(target, address); - if (retval != ERROR_OK) - return retval; /* enable MMU as we could have disabled it for phys access */ retval = aarch64_mmu_modify(target, 1); if (retval != ERROR_OK) -- ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot _______________________________________________ OpenOCD-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openocd-devel
