This is an automated email from Gerrit. Stafford Horne ([email protected]) just uploaded a new patch set to Gerrit, which you can find at http://openocd.zylin.com/4093
-- gerrit commit 5807193e5a8ab9247f5f6b96905a79e40941f6ff Author: Stafford Horne <[email protected]> Date: Wed Apr 5 06:11:30 2017 +0900 openrisc: Fix segv jsp due to free of unallocated data The prompt pointer in the jtag serial port is never zero'd or allocated. Completely remove it since there is not much use for it as the target software will provide the actual prompt. Change-Id: Id95d8ccb9f725e53b9d03386b11d91eba1cd6ef4 Signed-off-by: Stafford Horne <[email protected]> diff --git a/src/target/openrisc/jsp_server.c b/src/target/openrisc/jsp_server.c index e581fb8..0588a00 100644 --- a/src/target/openrisc/jsp_server.c +++ b/src/target/openrisc/jsp_server.c @@ -184,14 +184,8 @@ static int jsp_input(struct connection *connection) static int jsp_connection_closed(struct connection *connection) { - struct telnet_connection *t_con = connection->priv; struct jsp_service *jsp_service = connection->service->priv; - if (t_con->prompt) { - free(t_con->prompt); - t_con->prompt = NULL; - } - int retval = target_unregister_timer_callback(&jsp_poll_read, jsp_service); if (ERROR_OK != retval) return retval; -- ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ OpenOCD-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openocd-devel
