This is an automated email from Gerrit.

Paul Fertser ([email protected]) just uploaded a new patch set to Gerrit, 
which you can find at http://openocd.zylin.com/4330

-- gerrit

commit ea9e712bfb407841a28fcec7256afd5cbf5dc0f7
Author: Paul Fertser <[email protected]>
Date:   Sat Jan 13 13:54:53 2018 +0300

    server: telnet: fix comparison between signed and unsigned warning
    
    Exposed with clang 4.0.0.
    
    Since tc->line_cursor is a signed int (-1 is (ab)used to suppress prompt
    during log output) and pos is unsigned as required by the semantics of
    this function an explicit cast is needed to suppress the warning when
    comparing the two.
    
    Change-Id: I17e3506553986ec2cf232b5bbd2a218c7bbd2dae
    Signed-off-by: Paul Fertser <[email protected]>

diff --git a/src/server/telnet_server.c b/src/server/telnet_server.c
index 06a9c7a..bfdd473 100644
--- a/src/server/telnet_server.c
+++ b/src/server/telnet_server.c
@@ -310,7 +310,7 @@ static void telnet_move_cursor(struct connection 
*connection, size_t pos)
 
        tc = connection->priv;
 
-       if (pos < tc->line_cursor) {
+       if ((int)pos < tc->line_cursor) {
                tmp = tc->line_cursor - pos;
 
                for (size_t i = 0; i < tmp; i += 16)

-- 

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
OpenOCD-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openocd-devel

Reply via email to