This is an automated email from Gerrit. Paul Fertser ([email protected]) just uploaded a new patch set to Gerrit, which you can find at http://openocd.zylin.com/4350
-- gerrit commit c29c43a3b69fbd28a08e9f904de47c93105b5e8e Author: Paul Fertser <[email protected]> Date: Wed Jan 17 17:31:58 2018 +0300 server: add safeguards against printing bogus port number Clang static checker emits "Assigned value is garbage or undefined" warning there as it can't prove that when the socket descriptor is AF_INET/SOCK_STREAM and getsockname doesn't return an error, sin_port is guaranteed to be filled in. Pacify it by obvious means. Change-Id: I43b5e5ceb41c07d523a81b34a25490c4c5f49a70 Signed-off-by: Paul Fertser <[email protected]> diff --git a/src/server/server.c b/src/server/server.c index 1e52e97..a613f85 100644 --- a/src/server/server.c +++ b/src/server/server.c @@ -299,11 +299,11 @@ int add_service(char *name, return ERROR_FAIL; } - struct sockaddr_in addr_in; + struct sockaddr_in addr_in = { 0 }; socklen_t addr_in_size = sizeof(addr_in); - getsockname(c->fd, (struct sockaddr *)&addr_in, &addr_in_size); - LOG_INFO("Listening on port %hu for %s connections", - ntohs(addr_in.sin_port), name); + if (getsockname(c->fd, (struct sockaddr *)&addr_in, &addr_in_size) == 0) + LOG_INFO("Listening on port %hu for %s connections", + ntohs(addr_in.sin_port), name); } else if (c->type == CONNECTION_STDINOUT) { c->fd = fileno(stdin); -- ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ OpenOCD-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openocd-devel
