This is an automated email from Gerrit.

Paul Fertser ([email protected]) just uploaded a new patch set to Gerrit, 
which you can find at http://openocd.zylin.com/4352

-- gerrit

commit 11682daa68b8e10f5d54a386d1b223d6580c47c6
Author: Paul Fertser <[email protected]>
Date:   Thu Jan 18 00:07:29 2018 +0300

    flash: nor: stm32l4x: fix warning in probe
    
    Reading options word can fail, so this needs to be handled.
    
    Reported by Clang static analyzer.
    
    Change-Id: I9754cab9c4446fa2b20d4b44b0e20724d1bc1beb
    Signed-off-by: Paul Fertser <[email protected]>

diff --git a/src/flash/nor/stm32l4x.c b/src/flash/nor/stm32l4x.c
index fa0c48b..6a1fa07 100644
--- a/src/flash/nor/stm32l4x.c
+++ b/src/flash/nor/stm32l4x.c
@@ -652,6 +652,9 @@ static int stm32l4_probe(struct flash_bank *bank)
        /* get options to for DUAL BANK. */
        retval = target_read_u32(target, STM32_FLASH_OPTR, &options);
 
+       if (retval != ERROR_OK)
+               return retval;
+
        /* only devices with < 1024 kiB may be set to single bank dual banks */
        if ((flash_size_in_kb == 1024) || !(options & OPT_DUALBANK))
                stm32l4_info->option_bytes.bank_b_start = 256;

-- 

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
OpenOCD-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openocd-devel

Reply via email to