On 04.04.2018 1:28, Tim Newsome wrote:
src/flash/nor/core.h defines:
|struct flash_bank { ... uint32_t base; /**< The base address of this bank */ uint32_t size; /**< The size of this chip bank, in bytes */ |

Obviously this is limiting on targets that have 64-bit addresses.

Sure we need to change base to target_addr_t and maybe introduce a target_size_t? Probably there is no nor flash sized over 4GB but possible overflow in 32-bit size arithmetic should be prevented. I suppose the change would require some (lot of?) changes in the flash core and drivers too (printf formats...).
Feel free to make a patch.

I changed some occurrences of the flash address in http://openocd.zylin.com/4399
but this is far from complete, changes are just in touched code.
There are also possibly conflicting changes http://openocd.zylin.com/4297
and 4298 - I'm going to merge all of them soon.

Tom
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
OpenOCD-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openocd-devel

Reply via email to