This is an automated email from Gerrit.

Michael Brase ([email protected]) just uploaded a new patch set to 
Gerrit, which you can find at http://openocd.zylin.com/4662

-- gerrit

commit 47bc23253d9bf51f9dbda2dafc97a2bb1d72a86b
Author: Michael Brase <[email protected]>
Date:   Sun Sep 2 17:33:39 2018 -0500

    Prevent invalid MPSSE commands when NEG_EDGE_IN is set
    
    Make sure bit 2 (NEG_EDGE_IN) is clear when doing an MPSEE
    command which doesn't do a read.  This can cause invalid
    command op codes.
    
    Change-Id: I88e6a0cf5e10da41e366620031723fde7456c355
    Signed-off-by: Michael Brase <[email protected]>

diff --git a/src/jtag/drivers/mpsse.c b/src/jtag/drivers/mpsse.c
index 06d008b..38f6c8d 100644
--- a/src/jtag/drivers/mpsse.c
+++ b/src/jtag/drivers/mpsse.c
@@ -512,6 +512,8 @@ void mpsse_clock_data(struct mpsse_ctx *ctx, const uint8_t 
*out, unsigned out_of
                mode |= 0x10;
        if (in)
                mode |= 0x20;
+       else
+               mode &= ~NEG_EDGE_IN;
 
        while (length > 0) {
                /* Guarantee buffer space enough for a minimum size transfer */
@@ -587,6 +589,8 @@ void mpsse_clock_tms_cs(struct mpsse_ctx *ctx, const 
uint8_t *out, unsigned out_
        mode |= 0x42;
        if (in)
                mode |= 0x20;
+       else
+               mode &= ~NEG_EDGE_IN;
 
        while (length > 0) {
                /* Guarantee buffer space enough for a minimum size transfer */

-- 

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
OpenOCD-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openocd-devel

Reply via email to