This is an automated email from Gerrit.

Antonio Borneo ([email protected]) just uploaded a new patch set to 
Gerrit, which you can find at http://openocd.zylin.com/4847

-- gerrit

commit b99ad1a9410a6a5ded831535dda353d723eedeb6
Author: Antonio Borneo <[email protected]>
Date:   Fri Jan 11 18:29:38 2019 +0100

    drivers/imx_gpio: fix polarity of srst and trst
    
    The comment above the function is correct, but the code set
    the GPIO with wrong (reversed) polarity.
    
    Change-Id: Ifd09688150d3d2018af73521e0da3926bb1b7f84
    Signed-off-by: Antonio Borneo <[email protected]>

diff --git a/src/jtag/drivers/imx_gpio.c b/src/jtag/drivers/imx_gpio.c
index 2a822af..f42692c 100644
--- a/src/jtag/drivers/imx_gpio.c
+++ b/src/jtag/drivers/imx_gpio.c
@@ -160,10 +160,10 @@ static int imx_gpio_swd_write(int tck, int tms, int tdi)
 static int imx_gpio_reset(int trst, int srst)
 {
        if (trst_gpio != -1)
-               trst ? gpio_set(trst_gpio) : gpio_clear(trst_gpio);
+               trst ? gpio_clear(trst_gpio) : gpio_set(trst_gpio);
 
        if (srst_gpio != -1)
-               srst ? gpio_set(srst_gpio) : gpio_clear(srst_gpio);
+               srst ? gpio_clear(srst_gpio) : gpio_set(srst_gpio);
 
        return ERROR_OK;
 }

-- 


_______________________________________________
OpenOCD-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openocd-devel

Reply via email to