Hi all, On Fri, Jan 17, 2020 at 7:23 AM Antonio Borneo <[email protected]> wrote: > > On Fri, Jan 17, 2020 at 3:37 PM Oleksij Rempel <[email protected]> wrote: > > > > Am 17.01.20 um 12:45 schrieb Antonio Borneo: > > > Hi, > > > last merged commit "jtag: drivers: xlnx-pcie-xvc: Add support for > > > Xilinx XVC/PCIe" > > > breaks the build if configure enables it with option > > > --enable-xlnx-pcie-xvc > > > > > > The commit was created before my changes in the adapter interface. I'm > > > surprised gerrit allowed the merge. > > > > > > I'm preparing a fix, but I cannot send it before 5~6 hours. > > > My fix will only guarantee to compile; I will let Moritz to verify the > > > functionality on his platform. > > > > > > In mean time, the broken commit is not compiled by default, since > > > excluded at configure time. Just do not enable it with the configure > > > flag --enable-xlnx-pcie-xvc > > > > Ooops... my first try to merge a patch ended in total disaster. > > Should I do some thing now and how to prevent it in the future? > > I don't think makes sense to revert the patch. Was ready for merge, so > let's fix it quickly. > Luckily it's not built by default, so the impact is limited.
First sorry about that, wasn't aware this could possibly even happen :-) > > Paul, > is there any method to force jenkins to rebuild a patch before merging > it? Maybe has to be rebased on top of master. If that's possible +1. I've gotten so used to CI doing the right thing, it didn't even occur to me to check this twice. Cheers, Moritz _______________________________________________ OpenOCD-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openocd-devel
