This is an automated email from Gerrit. Antonio Borneo ([email protected]) just uploaded a new patch set to Gerrit, which you can find at http://openocd.zylin.com/5607
-- gerrit commit f8547bc620112d6c0e9456d3d2c0200b254d63cd Author: Antonio Borneo <[email protected]> Date: Mon May 6 10:24:52 2019 +0200 [RFC] checkpatch: add list of typedef used in OpenOCD The checkpatch from Linux kernel v5.1 does not recognizes the specific types used in OpenOCD, e.g. "fd_set" and "Jim_Obj". As consequence, it consider "fd_set" as the name of a variable, then misinterpret the asterisk for the pointer "fd_set *" as a multiplication, thus suggest to add a space after the asterisk and replace "fd_set *x" with "fd_set * x". Let checkpatch recognize the typedef used in OpenOCD. Add a comment grabbed from OP-TEE code [1], not sure if it is really relevant. [1] https://github.com/OP-TEE/optee_os/commit/94db01ef448d Change-Id: Ibc295e6a8b47ffa88b50a6d510b7970760e5199d Signed-off-by: Antonio Borneo <[email protected]> diff --git a/.checkpatch.conf b/.checkpatch.conf index 888dd9b..812dba3 100644 --- a/.checkpatch.conf +++ b/.checkpatch.conf @@ -1,6 +1,8 @@ --max-line-length=120 --tab-size=4 +--typedefsfile tools/scripts/typedefs.txt + --ignore AVOID_EXTERNS --ignore CONST_STRUCT --ignore FILE_PATH_CHANGES diff --git a/tools/scripts/typedefs.txt b/tools/scripts/typedefs.txt new file mode 100644 index 0000000..0a8a2ec --- /dev/null +++ b/tools/scripts/typedefs.txt @@ -0,0 +1,10 @@ +# Note: please keep the entries in this file sorted in reverse alphabetical +# order (sort -r) otherwise checkpatch would ignore some entries that have +# a common radix (such as TEE_BigInt/TEE_BigIntFMM/TEE_BigIntFMMContext). +# Not sure if it is expected or if it will be fixed in upstream checkpatch +# at some point. + +__PLD_DEVICE_COMMAND +libusb_device_handle +Jim_Obj +fd_set -- _______________________________________________ OpenOCD-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openocd-devel
