This is an automated email from Gerrit.

Antonio Borneo ([email protected]) just uploaded a new patch set to 
Gerrit, which you can find at http://openocd.zylin.com/5672

-- gerrit

commit de9791eb8bf73f51cc7129ae92df997edbbc00f1
Author: Antonio Borneo <[email protected]>
Date:   Wed May 13 02:30:11 2020 +0200

    helper/command: simplify run_command()
    
    Now that the commands are registered using their full-name, the
    full-name is in argv[0].
    
    Don't rebuild the full-name but use directly argv[0].
    
    Change-Id: Ic9e469ac39276367b8c47527e70791ff470fefbc
    Signed-off-by: Antonio Borneo <[email protected]>

diff --git a/src/helper/command.c b/src/helper/command.c
index 8a9041d..3a8e979 100644
--- a/src/helper/command.c
+++ b/src/helper/command.c
@@ -559,20 +559,13 @@ static int run_command(struct command_context *context,
        int retval = c->handler(&cmd);
        if (retval == ERROR_COMMAND_SYNTAX_ERROR) {
                /* Print help for command */
-               char *full_name = command_name(c, ' ');
-               if (NULL != full_name) {
-                       command_run_linef(context, "usage %s", full_name);
-                       free(full_name);
-               }
+               command_run_linef(context, "usage %s", words[0]);
        } else if (retval == ERROR_COMMAND_CLOSE_CONNECTION) {
                /* just fall through for a shutdown request */
        } else {
-               if (retval != ERROR_OK) {
-                       char *full_name = command_name(c, ' ');
+               if (retval != ERROR_OK)
                        LOG_DEBUG("Command '%s' failed with error code %d",
-                                               full_name ? full_name : 
c->name, retval);
-                       free(full_name);
-               }
+                                               words[0], retval);
                /* Use the command output as the Tcl result */
                Jim_SetResult(context->interp, cmd.output);
        }

-- 


_______________________________________________
OpenOCD-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openocd-devel

Reply via email to