This is an automated email from Gerrit.

Tomas Vanek ([email protected]) just uploaded a new patch set to Gerrit, which you 
can find at http://openocd.zylin.com/5905

-- gerrit

commit 5b9c0adc18340b11f58643c85784038f4749116b
Author: Tomas Vanek <[email protected]>
Date:   Thu Oct 29 19:57:20 2020 +0100

    gdb_server: fix clang static analyzer warning
    
    Warning:    line 373, column 15
    Assigned value is garbage or undefined
    
    Most probably a false warning, building the hex string byte
    per byte seems too complicated for static analyze.
    
    Change malloc to calloc to silence the warning.
    
    Change-Id: I746d43fa51abf05582ccf2680ed72dc557798a7a
    Signed-off-by: Tomas Vanek <[email protected]>

diff --git a/src/server/gdb_server.c b/src/server/gdb_server.c
index c369665..1a209a7 100644
--- a/src/server/gdb_server.c
+++ b/src/server/gdb_server.c
@@ -1332,7 +1332,7 @@ static int gdb_get_register_packet(struct connection 
*connection,
                }
        }
 
-       reg_packet = malloc(DIV_ROUND_UP(reg_list[reg_num]->size, 8) * 2 + 1); 
/* plus one for string termination null */
+       reg_packet = calloc(DIV_ROUND_UP(reg_list[reg_num]->size, 8) * 2 + 1, 
1); /* plus one for string termination null */
 
        gdb_str_to_target(target, reg_packet, reg_list[reg_num]);
 

-- 


_______________________________________________
OpenOCD-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openocd-devel

Reply via email to