This is an automated email from Gerrit.

Peter Mamonov ([email protected]) just uploaded a new patch set to Gerrit, 
which you can find at http://openocd.zylin.com/6058

-- gerrit

commit 6cdd64fc1458ccb24c638bd38852c0564e309491
Author: Peter Mamonov <[email protected]>
Date:   Mon Oct 12 15:02:44 2020 +0300

    target: use proper macro for parsing watchpoint address
    
    Currently wp/rwp commands fail on 64-bit targets:
    
        > wp 0xffffffff80001400 4
        addr option value ('0xffffffff80001400') is not valid
    
    Change-Id: I94d4af906b02b7bd463c8d79a6235a3646dfc434
    Signed-off-by: Peter Mamonov <[email protected]>

diff --git a/src/target/target.c b/src/target/target.c
index fa98c88..033fc07 100644
--- a/src/target/target.c
+++ b/src/target/target.c
@@ -4056,7 +4056,7 @@ COMMAND_HANDLER(handle_wp_command)
        }
 
        enum watchpoint_rw type = WPT_ACCESS;
-       uint32_t addr = 0;
+       target_addr_t addr = 0;
        uint32_t length = 0;
        uint32_t data_value = 0x0;
        uint32_t data_mask = 0xffffffff;
@@ -4086,7 +4086,7 @@ COMMAND_HANDLER(handle_wp_command)
                /* fall through */
        case 2:
                COMMAND_PARSE_NUMBER(u32, CMD_ARGV[1], length);
-               COMMAND_PARSE_NUMBER(u32, CMD_ARGV[0], addr);
+               COMMAND_PARSE_ADDRESS(CMD_ARGV[0], addr);
                break;
 
        default:
@@ -4106,8 +4106,8 @@ COMMAND_HANDLER(handle_rwp_command)
        if (CMD_ARGC != 1)
                return ERROR_COMMAND_SYNTAX_ERROR;
 
-       uint32_t addr;
-       COMMAND_PARSE_NUMBER(u32, CMD_ARGV[0], addr);
+       target_addr_t addr;
+       COMMAND_PARSE_ADDRESS(CMD_ARGV[0], addr);
 
        struct target *target = get_current_target(CMD_CTX);
        watchpoint_remove(target, addr);

-- 


_______________________________________________
OpenOCD-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openocd-devel

Reply via email to