This is an automated email from Gerrit.

Jan Matyas ([email protected]) just uploaded a new patch set to Gerrit, which 
you can find at http://openocd.zylin.com/6287

-- gerrit

commit 7a7d830e0703e17f5a72bc872968d5e05adfd475
Author: Jan Matyas <[email protected]>
Date:   Thu Jun 3 16:55:50 2021 +0200

    rtos: add serveral debug prints for the symbol lookup
    
    - Added several debug prints that allow to inspect the symbol
      lookup process (via the qSymbol packets).
    
    - Added a check for an edge situation when the debugger
      would send us different symbol than what we asked for
      (avoids NULL dereference).
    
    Change-Id: I84ae1b2b66473eab76a7966c678d2777b6ef48d6
    Signed-off-by: Jan Matyas <[email protected]>

diff --git a/src/rtos/rtos.c b/src/rtos/rtos.c
index fdb3862..6fcbc27 100644
--- a/src/rtos/rtos.c
+++ b/src/rtos/rtos.c
@@ -266,8 +266,17 @@ int rtos_qsymbol(struct connection *connection, char const 
*packet, int packet_s
                        cur_sym[0] = '\x00';
                }
        }
+
+       LOG_DEBUG("RTOS: Address of symbol '%s' is 0x%" PRIx64, cur_sym, addr);
+
        next_sym = next_symbol(os, cur_sym, addr);
 
+       /* Should never happen unless the debugger misbehaves */
+       if (next_sym == NULL) {
+               LOG_WARNING("RTOS: Debugger sent us qSymbol with '%s' that we 
did not ask for", cur_sym);
+               goto done;
+       }
+
        if (!next_sym->symbol_name) {
                /* No more symbols need looking up */
 
@@ -291,6 +300,8 @@ int rtos_qsymbol(struct connection *connection, char const 
*packet, int packet_s
                goto done;
        }
 
+       LOG_DEBUG("RTOS: Requesting symbol lookup of '%s' from the debugger", 
next_sym->symbol_name);
+
        reply_len = snprintf(reply, sizeof(reply), "qSymbol:");
        reply_len += hexify(reply + reply_len,
                (const uint8_t *)next_sym->symbol_name, 
strlen(next_sym->symbol_name),

-- 

Reply via email to