[PATCH]: 6ac8baf target/dsp563xx: Handle return values

[gerrit]

This is an automated email from Gerrit.

Marc Schink (d...@zapb.de) just uploaded a new patch set to Gerrit, which you 
can find at http://openocd.zylin.com/6323

-- gerrit

commit 6ac8bafa2662606a160e009b6976d2d30a041446
Author: Marc Schink <d...@zapb.de>
Date:   Thu Jun 17 15:47:11 2021 +0200

    target/dsp563xx: Handle return values
    
    This fixes 'dead assignment' bugs identified by the clang static analyzer.
    
    Change-Id: I140ed55f0043e06a533f45f50a36887614585b04
    Signed-off-by: Marc Schink <d...@zapb.de>

diff --git a/src/target/dsp563xx.c b/src/target/dsp563xx.c
index 21bed89..eb54661 100644
--- a/src/target/dsp563xx.c
+++ b/src/target/dsp563xx.c
@@ -1085,8 +1085,20 @@ static int dsp563xx_poll(struct target *target)
 
        if (!dsp563xx->hardware_breakpoints_cleared) {
                err = dsp563xx_once_reg_write(target->tap, 1, 
DSP563XX_ONCE_OBCR, 0);
+
+               if (err != ERROR_OK)
+                       return err;
+
                err = dsp563xx_once_reg_write(target->tap, 1, 
DSP563XX_ONCE_OMLR0, 0);
+
+               if (err != ERROR_OK)
+                       return err;
+
                err = dsp563xx_once_reg_write(target->tap, 1, 
DSP563XX_ONCE_OMLR1, 0);
+
+               if (err != ERROR_OK)
+                       return err;
+
                dsp563xx->hardware_breakpoints_cleared = 1;
        }
 

--