[PATCH]: 79a44c1 target/arm_tpiu: Fix 'tpiu create' parameter check

[gerrit]

This is an automated email from Gerrit.

Marc Schink (d...@zapb.de) just uploaded a new patch set to Gerrit, which you 
can find at http://openocd.zylin.com/6329

-- gerrit

commit 79a44c1aa1b41240ca644b298de670237882fd6a
Author: Marc Schink <d...@zapb.de>
Date:   Tue Jun 22 12:59:01 2021 +0200

    target/arm_tpiu: Fix 'tpiu create' parameter check
    
    The current implementation crashes when executing 'tpiu create'
    without an object name due to an invalid memory access. Pass 'argv'
    instead 'goi.argv' to fix the problem.
    
    While at it, match the style of the error mesage to the style used for
    other Tcl commands. Especially, make the 'name' parameter mandatory.
    
    Change-Id: Ib2b233f8556934af61608ae93d6405585c2c40b7
    Signed-off-by: Marc Schink <d...@zapb.de>

diff --git a/src/target/arm_tpiu_swo.c b/src/target/arm_tpiu_swo.c
index e8fca06..2f2b04e 100644
--- a/src/target/arm_tpiu_swo.c
+++ b/src/target/arm_tpiu_swo.c
@@ -901,7 +901,7 @@ static int jim_arm_tpiu_swo_create(Jim_Interp *interp, int 
argc, Jim_Obj *const
        struct jim_getopt_info goi;
        jim_getopt_setup(&goi, interp, argc - 1, argv + 1);
        if (goi.argc < 1) {
-               Jim_WrongNumArgs(goi.interp, 1, goi.argv, "?name? 
..options...");
+               Jim_WrongNumArgs(interp, 1, argv, "name ?option option ...?");
                return JIM_ERR;
        }
 

--