This is an automated email from Gerrit. Tarek BOCHKATI ([email protected]) just uploaded a new patch set to Gerrit, which you can find at http://openocd.zylin.com/6421
-- gerrit commit 660f835be10532ed523d418f0280c1238b5846dd Author: Tarek BOCHKATI <[email protected]> Date: Thu Jul 29 23:45:38 2021 +0100 flash/xmc4xxx: use COMMAND_PARSE_NUMBER in command handlers the usage of COMMAND_PARSE_NUMBER is safer in COMMAND_HANDLERs since it provides better error checking than strto** functions. Change-Id: Ibfe95ce73f147f467de8de23e9573ef0179aed96 Signed-off-by: Tarek BOCHKATI <[email protected]> diff --git a/src/flash/nor/xmc4xxx.c b/src/flash/nor/xmc4xxx.c index 04734d1..b0780a4 100644 --- a/src/flash/nor/xmc4xxx.c +++ b/src/flash/nor/xmc4xxx.c @@ -1270,12 +1270,12 @@ COMMAND_HANDLER(xmc4xxx_handle_flash_password_command) errno = 0; /* We skip over the flash bank */ - fb->pw1 = strtol(CMD_ARGV[1], NULL, 16); + COMMAND_PARSE_NUMBER(u32, CMD_ARGV[1], fb->pw1); if (errno) return ERROR_COMMAND_SYNTAX_ERROR; - fb->pw2 = strtol(CMD_ARGV[2], NULL, 16); + COMMAND_PARSE_NUMBER(u32, CMD_ARGV[2], fb->pw2); if (errno) return ERROR_COMMAND_SYNTAX_ERROR; --
