[PATCH]: 6b3cce9 isspace and isprint take int ref https://sourceforge.net/p/openocd/tickets/315/ Change-Id: I71fcfc28f0cb7d74257edf6ac6a9a6d1fc2b9947 Signed-off-by: Benjamin Shirley-Quirk

[gerrit]

This is an automated email from Gerrit.

Benjamin Shirley-Quirk (shirleyqu...@gmail.com) just uploaded a new patch set 
to Gerrit, which you can find at http://openocd.zylin.com/6444

-- gerrit

commit 6b3cce941fd1981f42e6ca634503f46fea280390
Author: Benjamin Shirley-Quirk <shirleyqu...@gmail.com>
Date:   Fri Aug 20 13:44:35 2021 +0100

    isspace and isprint take int
    ref https://sourceforge.net/p/openocd/tickets/315/
    Change-Id: I71fcfc28f0cb7d74257edf6ac6a9a6d1fc2b9947
    Signed-off-by: Benjamin Shirley-Quirk <shirleyqu...@gmail.com>

diff --git a/src/helper/log.c b/src/helper/log.c
index caa0a66..49d75d3 100644
--- a/src/helper/log.c
+++ b/src/helper/log.c
@@ -526,7 +526,7 @@ void log_socket_error(const char *socket_desc)
 char *find_nonprint_char(char *buf, unsigned buf_len)
 {
        for (unsigned int i = 0; i < buf_len; i++) {
-               if (!isprint(buf[i]))
+               if (!isprint((int)buf[i]))
                        return buf + i;
        }
        return NULL;
diff --git a/src/server/telnet_server.c b/src/server/telnet_server.c
index 697efa1..33ffbfb 100644
--- a/src/server/telnet_server.c
+++ b/src/server/telnet_server.c
@@ -446,7 +446,7 @@ static void telnet_auto_complete(struct connection 
*connection)
 
        /* user command position in the line, ignore leading spaces */
        size_t usr_cmd_pos = seq_start;
-       while ((usr_cmd_pos < t_con->line_cursor) && 
isspace(t_con->line[usr_cmd_pos]))
+       while ((usr_cmd_pos < t_con->line_cursor) && 
isspace((int)t_con->line[usr_cmd_pos]))
                usr_cmd_pos++;
 
        /* user command length */
@@ -457,8 +457,8 @@ static void telnet_auto_complete(struct connection 
*connection)
        size_t optimized_spaces = 0;
        char query[usr_cmd_len + 1];
        for (size_t i = 0; i < usr_cmd_len; i++) {
-               if ((i < usr_cmd_len - 1) && isspace(t_con->line[usr_cmd_pos + 
i])
-                               && isspace(t_con->line[usr_cmd_pos + i + 1])) {
+               if ((i < usr_cmd_len - 1) && 
isspace((int)t_con->line[usr_cmd_pos + i])
+                               && isspace((int)t_con->line[usr_cmd_pos + i + 
1])) {
                        optimized_spaces++;
                        continue;
                }

--