[PATCH]: 9d48e8809 server: fix: remove kept_alive() from server loop

[gerrit]

This is an automated email from Gerrit.

"Antonio Borneo <borneo.anto...@gmail.com>" just uploaded a new patch set to 
Gerrit, which you can find at https://review.openocd.org/c/openocd/+/6836

-- gerrit

commit 9d48e88093b5fb5f7d449f011902870aa34d3227
Author: Antonio Borneo <borneo.anto...@gmail.com>
Date:   Sun Jan 30 23:57:38 2022 +0100

    server: fix: remove kept_alive() from server loop
    
    The kept_alive() action is specific of a server that enjoyed an
    unscheduled keep_alive and want to communicate it to the keep
    alive logic to reschedule next keep_alive().
    In server loop we are not expected to call kept_alive().
    Remove it!
    
    This call was erroneously added in commit 94e75e0c06c4.
    Later, commit 7442b26d45dc properly added the same call in
    gdb_put_packet(), but incorrectly left the older in place.
    
    Change-Id: If476410f870eebfbdaccdb1366ba2e9254e2fdf6
    Signed-off-by: Antonio Borneo <borneo.anto...@gmail.com>

diff --git a/src/server/server.c b/src/server/server.c
index 3f579bfc6..b7e03fe52 100644
--- a/src/server/server.c
+++ b/src/server/server.c
@@ -488,7 +488,6 @@ int server_loop(struct command_context *command_context)
                        tv.tv_usec = timeout_ms * 1000;
                        /* Only while we're sleeping we'll let others run */
                        openocd_sleep_prelude();
-                       kept_alive();
                        retval = socket_select(fd_max + 1, &read_fds, NULL, 
NULL, &tv);
                        openocd_sleep_postlude();
                }

--