[PATCH]: ebd83222a5 jimtcl: add configure flag for build maintainer mode

[gerrit]

This is an automated email from Gerrit.

"Antonio Borneo <borneo.anto...@gmail.com>" just uploaded a new patch set to 
Gerrit, which you can find at https://review.openocd.org/c/openocd/+/6871

-- gerrit

commit ebd83222a59bbb45cc700d8e239fcb5143e4386a
Author: Antonio Borneo <borneo.anto...@gmail.com>
Date:   Sat Mar 5 14:00:04 2022 +0100

    jimtcl: add configure flag for build maintainer mode
    
    When jimtcl is built in maintainer mode, it runs extra tests at
    exit to look for memory leak due to jim objects not properly freed
    either through Jim_IncrRefCount()/Jim_DecrRefCount() or by passing
    it to a jim API.
    
    Add optional OpenOCD configure flag '--enable-jimtcl-maintainer'
    to enable jimtcl maintainer mode.
    
    Modify the implementation of macro AX_CONFIG_SUBDIR_OPTION to
    allow expanding a variable passed as second argument.
    
    Change-Id: Id1a39b25cee3773b172faf70803fa150182f0cd6
    Signed-off-by: Antonio Borneo <borneo.anto...@gmail.com>

diff --git a/config_subdir.m4 b/config_subdir.m4
index 45a1c6c4fb..2be590e44a 100644
--- a/config_subdir.m4
+++ b/config_subdir.m4
@@ -7,6 +7,6 @@ AC_DEFUN([AX_CONFIG_SUBDIR_OPTION],
 AC_CONFIG_SUBDIRS([$1])
 
 m4_ifblank([$2], [rm -f $srcdir/$1/configure.gnu],
-[echo -e '#!/bin/sh\nexec "`dirname "'\$'0"`/configure" $2 "'\$'@"' > 
"$srcdir/$1/configure.gnu"
+[echo -e '#!/bin/sh\nexec "`dirname "'\$'0"`/configure" '"$2"' "'\$'@"' > 
"$srcdir/$1/configure.gnu"
 ])
 ])
diff --git a/configure.ac b/configure.ac
index 68fff45c1f..15d7229a4f 100644
--- a/configure.ac
+++ b/configure.ac
@@ -354,6 +354,10 @@ AC_ARG_ENABLE([internal-jimtcl],
   AS_HELP_STRING([--disable-internal-jimtcl], [Disable building internal 
jimtcl]),
   [use_internal_jimtcl=$enableval], [use_internal_jimtcl=yes])
 
+AC_ARG_ENABLE([jimtcl-maintainer],
+  AS_HELP_STRING([--enable-jimtcl-maintainer], [Enable maintainer mode when 
building internal jimtcl]),
+  [use_internal_jimtcl_maintainer=$enableval], 
[use_internal_jimtcl_maintainer=no])
+
 AC_ARG_ENABLE([internal-libjaylink],
   AS_HELP_STRING([--disable-internal-libjaylink],
   [Disable building internal libjaylink]),
@@ -550,7 +554,12 @@ AS_IF([test "x$enable_buspirate" != "xno"], [
 
 AS_IF([test "x$use_internal_jimtcl" = "xyes"], [
   AS_IF([test -f "$srcdir/jimtcl/configure.ac"], [
-    AX_CONFIG_SUBDIR_OPTION([jimtcl], [--disable-install-jim])
+    AS_IF([test "x$use_internal_jimtcl_maintainer" = "xyes"], [
+      jimtcl_config_options="--disable-install-jim --maintainer"
+    ], [
+      jimtcl_config_options="--disable-install-jim"
+    ])
+    AX_CONFIG_SUBDIR_OPTION([jimtcl], [$jimtcl_config_options])
   ], [
     AC_MSG_ERROR([jimtcl not found, run git submodule init and git submodule 
update.])
   ])

--