This is an automated email from Gerrit.

"Tomas Vanek <van...@fbl.cz>" just uploaded a new patch set to Gerrit, which 
you can find at https://review.openocd.org/c/openocd/+/7106

-- gerrit

commit c730e91b1c95661db7d452b84665b68966d1910a
Author: Tomas Vanek <van...@fbl.cz>
Date:   Mon Aug 1 23:16:47 2022 +0200

    jtag/drivers/kitprog: use HID read timeout
    
    Use hid_read_timeout() instead of hid_read().
    Improve error messages.
    
    Change-Id: Ia75b4fcd610442ab926bc454341f928d59843fcf
    Signed-off-by: Tomas Vanek <van...@fbl.cz>

diff --git a/src/jtag/drivers/kitprog.c b/src/jtag/drivers/kitprog.c
index 0956d3aa6d..7122d57575 100644
--- a/src/jtag/drivers/kitprog.c
+++ b/src/jtag/drivers/kitprog.c
@@ -321,9 +321,13 @@ static int kitprog_hid_command(uint8_t *command, size_t 
command_length,
                return ERROR_FAIL;
        }
 
-       ret = hid_read(kitprog_handle->hid_handle, data, data_length);
-       if (ret < 0) {
-               LOG_DEBUG("HID read returned %i", ret);
+       ret = hid_read_timeout(kitprog_handle->hid_handle,
+                                                       data, data_length, 
LIBUSB_TIMEOUT_MS);
+       if (ret == 0) {
+               LOG_ERROR("HID read timed out");
+               return ERROR_TIMEOUT_REACHED;
+       } else if (ret < 0) {
+               LOG_ERROR("HID read error %ls", 
hid_error(kitprog_handle->hid_handle));
                return ERROR_FAIL;
        }
 

-- 

Reply via email to