This is an automated email from Gerrit.

"Antonio Borneo <borneo.anto...@gmail.com>" just uploaded a new patch set to 
Gerrit, which you can find at https://review.openocd.org/c/openocd/+/7120

-- gerrit

commit c097032bbd7f60aadce1c986052ad7a04a8a482a
Author: Antonio Borneo <borneo.anto...@gmail.com>
Date:   Tue Aug 16 11:42:32 2022 +0200

    flash/nor: remove empty command definitions
    
    The value of struct flash_driver::command can be NULL when the
    flash driver does not need to add any new command.
    
    Remove empty command definitions.
    
    Change-Id: I5413967d4069030234469822d24e9825425ae012
    Signed-off-by: Antonio Borneo <borneo.anto...@gmail.com>

diff --git a/src/flash/nor/fm4.c b/src/flash/nor/fm4.c
index 2881f1201f..3a362d888e 100644
--- a/src/flash/nor/fm4.c
+++ b/src/flash/nor/fm4.c
@@ -688,24 +688,8 @@ FLASH_BANK_COMMAND_HANDLER(fm4_flash_bank_command)
        return ret;
 }
 
-static const struct command_registration fm4_exec_command_handlers[] = {
-       COMMAND_REGISTRATION_DONE
-};
-
-static const struct command_registration fm4_command_handlers[] = {
-       {
-               .name = "fm4",
-               .mode = COMMAND_ANY,
-               .help = "fm4 flash command group",
-               .usage = "",
-               .chain = fm4_exec_command_handlers,
-       },
-       COMMAND_REGISTRATION_DONE
-};
-
 const struct flash_driver fm4_flash = {
        .name = "fm4",
-       .commands = fm4_command_handlers,
        .flash_bank_command = fm4_flash_bank_command,
        .info = fm4_get_info_command,
        .probe = fm4_probe,
diff --git a/src/flash/nor/psoc5lp.c b/src/flash/nor/psoc5lp.c
index a8265bc239..b546b0aa0b 100644
--- a/src/flash/nor/psoc5lp.c
+++ b/src/flash/nor/psoc5lp.c
@@ -811,24 +811,8 @@ FLASH_BANK_COMMAND_HANDLER(psoc5lp_nvl_flash_bank_command)
        return ERROR_OK;
 }
 
-static const struct command_registration psoc5lp_nvl_exec_command_handlers[] = 
{
-       COMMAND_REGISTRATION_DONE
-};
-
-static const struct command_registration psoc5lp_nvl_command_handlers[] = {
-       {
-               .name = "psoc5lp_nvl",
-               .mode = COMMAND_ANY,
-               .help = "PSoC 5LP NV Latch command group",
-               .usage = "",
-               .chain = psoc5lp_nvl_exec_command_handlers,
-       },
-       COMMAND_REGISTRATION_DONE
-};
-
 const struct flash_driver psoc5lp_nvl_flash = {
        .name = "psoc5lp_nvl",
-       .commands = psoc5lp_nvl_command_handlers,
        .flash_bank_command = psoc5lp_nvl_flash_bank_command,
        .info = psoc5lp_nvl_get_info_command,
        .probe = psoc5lp_nvl_probe,
@@ -1010,24 +994,8 @@ 
FLASH_BANK_COMMAND_HANDLER(psoc5lp_eeprom_flash_bank_command)
        return ERROR_OK;
 }
 
-static const struct command_registration 
psoc5lp_eeprom_exec_command_handlers[] = {
-       COMMAND_REGISTRATION_DONE
-};
-
-static const struct command_registration psoc5lp_eeprom_command_handlers[] = {
-       {
-               .name = "psoc5lp_eeprom",
-               .mode = COMMAND_ANY,
-               .help = "PSoC 5LP EEPROM command group",
-               .usage = "",
-               .chain = psoc5lp_eeprom_exec_command_handlers,
-       },
-       COMMAND_REGISTRATION_DONE
-};
-
 const struct flash_driver psoc5lp_eeprom_flash = {
        .name = "psoc5lp_eeprom",
-       .commands = psoc5lp_eeprom_command_handlers,
        .flash_bank_command = psoc5lp_eeprom_flash_bank_command,
        .info = psoc5lp_eeprom_get_info_command,
        .probe = psoc5lp_eeprom_probe,
diff --git a/src/flash/nor/xmc1xxx.c b/src/flash/nor/xmc1xxx.c
index 70e07fcfaa..04a39f36e1 100644
--- a/src/flash/nor/xmc1xxx.c
+++ b/src/flash/nor/xmc1xxx.c
@@ -520,24 +520,8 @@ FLASH_BANK_COMMAND_HANDLER(xmc1xxx_flash_bank_command)
        return ERROR_OK;
 }
 
-static const struct command_registration xmc1xxx_exec_command_handlers[] = {
-       COMMAND_REGISTRATION_DONE
-};
-
-static const struct command_registration xmc1xxx_command_handlers[] = {
-       {
-               .name = "xmc1xxx",
-               .mode = COMMAND_ANY,
-               .help = "xmc1xxx flash command group",
-               .usage = "",
-               .chain = xmc1xxx_exec_command_handlers,
-       },
-       COMMAND_REGISTRATION_DONE
-};
-
 const struct flash_driver xmc1xxx_flash = {
        .name = "xmc1xxx",
-       .commands = xmc1xxx_command_handlers,
        .flash_bank_command = xmc1xxx_flash_bank_command,
        .info = xmc1xxx_get_info_command,
        .probe = xmc1xxx_probe,

-- 

Reply via email to