This is an automated email from Gerrit.

"Antonio Borneo <borneo.anto...@gmail.com>" just uploaded a new patch set to 
Gerrit, which you can find at https://review.openocd.org/c/openocd/+/7175

-- gerrit

commit dad80d7b2eddb0c9e79017bc04bf90b2c07d3868
Author: Antonio Borneo <borneo.anto...@gmail.com>
Date:   Tue Sep 6 17:55:44 2022 +0200

    configure.ac: drop unneeded dependency check
    
    The script configure.ac checks for the presence of system include
    files required to build OpenOCD.
    
    It incorrectly check for:
            dirent.h
            pthread.h
            ifaddrs.h
            net/if.h
    that are never included by OpenOCD source code, plus the generated
    macros:
            HAVE_DIRENT_H
            HAVE_PTHREAD_H
            HAVE_IFADDRS_H
            HAVE_NET_IF_H
    are never used in OpenOCD source code.
    
    It also checks for the system function:
            vasprintf()
    that is never called by OpenOCD source code, plus the generated
    macro:
            HAVE_VASPRINTF
    is never used in OpenOCD source code.
    
    Drop the checks for the unused system include files and the unused
    system function.
    
    Change-Id: I68c1b1a1be268a830247fc489f210877c32d7d23
    Signed-off-by: Antonio Borneo <borneo.anto...@gmail.com>

diff --git a/configure.ac b/configure.ac
index 7d0cc24698..8e1f11e2d7 100644
--- a/configure.ac
+++ b/configure.ac
@@ -55,12 +55,10 @@ AC_CHECK_HEADERS([elf.h])
 AC_EGREP_HEADER(Elf64_Ehdr, [elf.h], [
   AC_DEFINE([HAVE_ELF64], [1], [Define to 1 if the system has the type 
`Elf64_Ehdr'.])
 ])
-AC_CHECK_HEADERS([dirent.h])
 AC_CHECK_HEADERS([fcntl.h])
 AC_CHECK_HEADERS([malloc.h])
 AC_CHECK_HEADERS([netdb.h])
 AC_CHECK_HEADERS([poll.h])
-AC_CHECK_HEADERS([pthread.h])
 AC_CHECK_HEADERS([strings.h])
 AC_CHECK_HEADERS([sys/ioctl.h])
 AC_CHECK_HEADERS([sys/param.h])
@@ -70,7 +68,7 @@ AC_CHECK_HEADERS([sys/sysctl.h])
 AC_CHECK_HEADERS([sys/time.h])
 AC_CHECK_HEADERS([sys/types.h])
 AC_CHECK_HEADERS([unistd.h])
-AC_CHECK_HEADERS([arpa/inet.h ifaddrs.h netinet/in.h netinet/tcp.h net/if.h], 
[], [], [dnl
+AC_CHECK_HEADERS([arpa/inet.h netinet/in.h netinet/tcp.h], [], [], [dnl
 #include <stdio.h>
 #ifdef STDC_HEADERS
 # include <stdlib.h>
@@ -94,7 +92,6 @@ AC_CHECK_FUNCS([strndup])
 AC_CHECK_FUNCS([strnlen])
 AC_CHECK_FUNCS([gettimeofday])
 AC_CHECK_FUNCS([usleep])
-AC_CHECK_FUNCS([vasprintf])
 AC_CHECK_FUNCS([realpath])
 
 # guess-rev.sh only exists in the repository, not in the released archives

-- 

Reply via email to