[PATCH]: ed6edb2773 target/riscv: fix dead assignment

[gerrit]

This is an automated email from Gerrit.

"Antonio Borneo <borneo.anto...@gmail.com>" just uploaded a new patch set to 
Gerrit, which you can find at https://review.openocd.org/c/openocd/+/7208

-- gerrit

commit ed6edb277397d451e18e228d7a5924b0d587b794
Author: Antonio Borneo <borneo.anto...@gmail.com>
Date:   Mon Sep 19 15:02:36 2022 +0200

    target/riscv: fix dead assignment
    
    Scan-build reports:
            Unused code: Dead nested assignment
            riscv.c:459 Although the value stored to 'ir_user4_raw' is
                    used in the enclosing expression, the value is
                    never actually read from 'ir_user4_raw'
    
    This is caused by the value reassigned in 'ir_user4_raw':
            riscv.c:459 ir_user4[3] = (uint8_t)(ir_user4_raw >>= 8);
    but never used.
    
    Drop the DIY conversion in favor of h_u32_to_le() that does not
    reassign the input value.
    
    Change-Id: Ifad29f4c46d4a2d0a2f5a5c4104d768cc3db2794
    Signed-off-by: Antonio Borneo <borneo.anto...@gmail.com>

diff --git a/src/target/riscv/riscv.c b/src/target/riscv/riscv.c
index c25efcde9a..5444fca01b 100644
--- a/src/target/riscv/riscv.c
+++ b/src/target/riscv/riscv.c
@@ -453,10 +453,7 @@ static int riscv_init_target(struct command_context 
*cmd_ctx,
        if (bscan_tunnel_ir_width != 0) {
                assert(target->tap->ir_length >= 6);
                uint32_t ir_user4_raw = 0x23 << (target->tap->ir_length - 6);
-               ir_user4[0] = (uint8_t)ir_user4_raw;
-               ir_user4[1] = (uint8_t)(ir_user4_raw >>= 8);
-               ir_user4[2] = (uint8_t)(ir_user4_raw >>= 8);
-               ir_user4[3] = (uint8_t)(ir_user4_raw >>= 8);
+               h_u32_to_le(ir_user4, ir_user4_raw);
                select_user4.num_bits = target->tap->ir_length;
                bscan_tunneled_ir_width[0] = bscan_tunnel_ir_width;
                if (bscan_tunnel_type == BSCAN_TUNNEL_DATA_REGISTER)

--