Hi, On Thu, Nov 24, 2022 at 10:10:59PM +0530, Kautuk Consul wrote: > So I managed to create a gerrit account and followed the instructions in > HACKING.
Thanks, you did everything right. > But, I got a build failure for mingw64 as given > by: [1]https://build.openocd.org/job/openocd-gerrit-build/16294/console See, from https://review.openocd.org/c/openocd/+/7377 you follow https://build.openocd.org/job/openocd-gerrit-build/16294/ , then mingw64, then Console Output leads to https://build.openocd.org/job/openocd-gerrit-build/16294/TARGET=mingw64/console so the problem is error: implicit declaration of fcntl function which is not surprising as OpenOCD needs to be buildable as a native Windows application and that platform lacks certain common functions. > Do I have to resolve this compilation problem before anyone reviews the patch > ? After you decide how to resolve it (probably by #ifdef'ing out your whole command when building for windows or probably by finding some windows-specific way) you just --amend the patch locally (do not change the Change-Id) and send it to Gerrit again the same way. HTH :) -- Be free, use free (http://www.gnu.org/philosophy/free-sw.html) software! mailto:fercer...@gmail.com
