This is an automated email from Gerrit.

"Antonio Borneo <borneo.anto...@gmail.com>" just uploaded a new patch set to 
Gerrit, which you can find at https://review.openocd.org/c/openocd/+/7437

-- gerrit

commit 1ecc7e89e5136e7344d5cf49ccd20c0cf82cdbd3
Author: Antonio Borneo <borneo.anto...@gmail.com>
Date:   Sat Jan 14 15:18:02 2023 +0100

    configure.ac: fix check for jimtcl submodule
    
    The file configure.ac checks if jimtcl submodule is present by
    looking for the file jimtcl/configure.ac .
    But jimtcl has switched to its own build system in 2011 and thus
    dropped configure.ac . This cause a build issue on OpenOCD that
    was incorrectly fixed by adding a dummy configure.ac in jimtcl.
    
    Fix OpenOCD configure.ac to look for the correct file
    jimtcl/configure .
    After this fix, another fix would be proposed to jimtcl to drop
    its useless dummy file configure.ac .
    
    Change-Id: I705f72d83e374c8dd700baaa0c0bbe041f153605
    Signed-off-by: Antonio Borneo <borneo.anto...@gmail.com>
    Reported-by: Paul Fertser <fercer...@gmail.com>

diff --git a/configure.ac b/configure.ac
index bcacfb2404..a8535213d1 100644
--- a/configure.ac
+++ b/configure.ac
@@ -574,7 +574,7 @@ AS_IF([test "x$enable_buspirate" != "xno"], [
 ])
 
 AS_IF([test "x$use_internal_jimtcl" = "xyes"], [
-  AS_IF([test -f "$srcdir/jimtcl/configure.ac"], [
+  AS_IF([test -f "$srcdir/jimtcl/configure"], [
     AS_IF([test "x$use_internal_jimtcl_maintainer" = "xyes"], [
       jimtcl_config_options="--disable-install-jim --with-ext=json 
--maintainer"
     ], [

-- 

Reply via email to