[PATCH]: 5a8f1454c5 target: rewrite command 'arp_poll' as COMMAND_HANDLER

[gerrit]

This is an automated email from Gerrit.

"Antonio Borneo <borneo.anto...@gmail.com>" just uploaded a new patch set to 
Gerrit, which you can find at https://review.openocd.org/c/openocd/+/7557

-- gerrit

commit 5a8f1454c580b7e507d6ff64d2300f5bc6edf969
Author: Antonio Borneo <borneo.anto...@gmail.com>
Date:   Mon Mar 27 10:34:14 2023 +0200

    target: rewrite command 'arp_poll' as COMMAND_HANDLER
    
    While there, add the missing .usage field.
    
    Change-Id: I16e0aeacdaaada09fa77ad29552fa4025eff0c45
    Signed-off-by: Antonio Borneo <borneo.anto...@gmail.com>

diff --git a/src/target/target.c b/src/target/target.c
index b6c4ecec76..29c549c54f 100644
--- a/src/target/target.c
+++ b/src/target/target.c
@@ -5751,26 +5751,21 @@ COMMAND_HANDLER(handle_target_halt_gdb)
        return target_call_event_callbacks(target, TARGET_EVENT_GDB_HALT);
 }
 
-static int jim_target_poll(Jim_Interp *interp, int argc, Jim_Obj *const *argv)
+COMMAND_HANDLER(handle_target_poll)
 {
-       if (argc != 1) {
-               Jim_WrongNumArgs(interp, 1, argv, "[no parameters]");
-               return JIM_ERR;
+       if (CMD_ARGC != 0)
+               return ERROR_COMMAND_SYNTAX_ERROR;
+
+       struct target *target = get_current_target(CMD_CTX);
+       if (!target->tap->enabled) {
+               command_print(CMD, "[TAP is disabled]");
+               return ERROR_FAIL;
        }
-       struct command_context *cmd_ctx = current_command_context(interp);
-       assert(cmd_ctx);
-       struct target *target = get_current_target(cmd_ctx);
-       if (!target->tap->enabled)
-               return jim_target_tap_disabled(interp);
 
-       int e;
        if (!(target_was_examined(target)))
-               e = ERROR_TARGET_NOT_EXAMINED;
-       else
-               e = target->type->poll(target);
-       if (e != ERROR_OK)
-               return JIM_ERR;
-       return JIM_OK;
+               return ERROR_TARGET_NOT_EXAMINED;
+
+       return target->type->poll(target);
 }
 
 static int jim_target_reset(Jim_Interp *interp, int argc, Jim_Obj *const *argv)
@@ -6098,8 +6093,9 @@ static const struct command_registration 
target_instance_command_handlers[] = {
        {
                .name = "arp_poll",
                .mode = COMMAND_EXEC,
-               .jim_handler = jim_target_poll,
+               .handler = handle_target_poll,
                .help = "used internally for reset processing",
+               .usage = "",
        },
        {
                .name = "arp_reset",

--