This is an automated email from Gerrit.

"Antonio Borneo <borneo.anto...@gmail.com>" just uploaded a new patch set to 
Gerrit, which you can find at https://review.openocd.org/c/openocd/+/7599

-- gerrit

commit b48eac0d6be1b82550a665ad85f472a859394384
Author: Antonio Borneo <borneo.anto...@gmail.com>
Date:   Sun Apr 9 01:00:15 2023 +0200

    target: etm: fix check trace status
    
    Current code tests a function pointer against a numeric value that
    is the same enum type as returned by the pointed function.
    Clearly the author was willing to call the function and check its
    returned value.
    
    Fix the check by calling the function.
    
    Detected through 'sparse' tool.
    
    Change-Id: I27d18d26c2c797160a397daa32835c199014b70b
    Signed-off-by: Antonio Borneo <borneo.anto...@gmail.com>
    Checkpatch-ignore: GIT_COMMIT_ID
    Fixes: 237e894805dd ("reworked etm/etb into a generic etm part with trace 
capture")

diff --git a/src/target/etm.c b/src/target/etm.c
index 57417c3fa8..6718875ee9 100644
--- a/src/target/etm.c
+++ b/src/target/etm.c
@@ -1706,7 +1706,7 @@ COMMAND_HANDLER(handle_etm_dump_command)
                return ERROR_FAIL;
        }
 
-       if (etm_ctx->capture_driver->status == TRACE_IDLE) {
+       if (etm_ctx->capture_driver->status(etm_ctx) == TRACE_IDLE) {
                command_print(CMD, "trace capture wasn't enabled, no trace data 
captured");
                return ERROR_OK;
        }

-- 

Reply via email to