[PATCH]: ef3a98a63a helper: with pointers, use NULL instead of 0

[gerrit]

This is an automated email from Gerrit.

"Antonio Borneo <borneo.anto...@gmail.com>" just uploaded a new patch set to 
Gerrit, which you can find at https://review.openocd.org/c/openocd/+/7597

-- gerrit

commit ef3a98a63a370dd1badffe9e5bfffefdd64d9cc8
Author: Antonio Borneo <borneo.anto...@gmail.com>
Date:   Sun Apr 9 00:16:28 2023 +0200

    helper: with pointers, use NULL instead of 0
    
    Don't compare pointers with 0, use NULL when needed.
    Don't assign pointer to 0, use NULL.
    Don't pass 0 ad pointer argument, pass NULL.
    
    Detected through 'sparse' tool.
    
    Change-Id: I3f867cb9c0903f6e396311e7b3970ee5fb3a4231
    Signed-off-by: Antonio Borneo <borneo.anto...@gmail.com>

diff --git a/src/helper/command.c b/src/helper/command.c
index 235bec8580..945b890b3a 100644
--- a/src/helper/command.c
+++ b/src/helper/command.c
@@ -582,7 +582,7 @@ int command_run_line(struct command_context *context, char 
*line)
                Jim_DeleteAssocData(interp, "retval");
                retcode = Jim_SetAssocData(interp, "retval", NULL, &retval);
                if (retcode == JIM_OK) {
-                       retcode = Jim_Eval_Named(interp, line, 0, 0);
+                       retcode = Jim_Eval_Named(interp, line, NULL, 0);
 
                        Jim_DeleteAssocData(interp, "retval");
                }
diff --git a/src/helper/jep106.c b/src/helper/jep106.c
index d422561bc2..62d24a9b23 100644
--- a/src/helper/jep106.c
+++ b/src/helper/jep106.c
@@ -26,7 +26,7 @@ const char *jep106_table_manufacturer(unsigned int bank, 
unsigned int id)
        /* index is zero based */
        id--;
 
-       if (bank >= ARRAY_SIZE(jep106) || jep106[bank][id] == 0)
+       if (bank >= ARRAY_SIZE(jep106) || !jep106[bank][id])
                return "<unknown>";
 
        return jep106[bank][id];
diff --git a/src/helper/options.c b/src/helper/options.c
index 327c418d0d..05cde6709f 100644
--- a/src/helper/options.c
+++ b/src/helper/options.c
@@ -39,12 +39,12 @@ static int help_flag, version_flag;
 static const struct option long_options[] = {
        {"help",                no_argument,                    &help_flag,     
        1},
        {"version",             no_argument,                    &version_flag,  
1},
-       {"debug",               optional_argument,              0,              
                'd'},
-       {"file",                required_argument,              0,              
                'f'},
-       {"search",              required_argument,              0,              
                's'},
-       {"log_output",  required_argument,              0,                      
        'l'},
-       {"command",             required_argument,              0,              
                'c'},
-       {0, 0, 0, 0}
+       {"debug",               optional_argument,              NULL,           
        'd'},
+       {"file",                required_argument,              NULL,           
        'f'},
+       {"search",              required_argument,              NULL,           
        's'},
+       {"log_output",  required_argument,              NULL,                   
'l'},
+       {"command",             required_argument,              NULL,           
        'c'},
+       {NULL, 0, NULL, 0}
 };
 
 int configuration_output_handler(struct command_context *context, const char 
*line)

--