This is an automated email from Gerrit.

"Antonio Borneo <borneo.anto...@gmail.com>" just uploaded a new patch set to 
Gerrit, which you can find at https://review.openocd.org/c/openocd/+/7675

-- gerrit

commit 8631c693395bd4f2b31d08d5630460fad53dc36a
Author: Antonio Borneo <borneo.anto...@gmail.com>
Date:   Sat May 6 22:17:36 2023 +0200

    target: arm_adi_v5: move in include file the declaration of dap_ops
    
    The struct containing SWD and JTAG operations are declared as
    extern in the C file.
    
    Mode them in include file arm_adi_v5.h to silent 'sparse' error
    for global variable definition without declaration in an include
    file.
    
    Change-Id: I59088512c052d5a120c38404a882ed512a68ca02
    Signed-off-by: Antonio Borneo <borneo.anto...@gmail.com>

diff --git a/src/target/arm_adi_v5.h b/src/target/arm_adi_v5.h
index 3eddbc0e2d..90d28bcf23 100644
--- a/src/target/arm_adi_v5.h
+++ b/src/target/arm_adi_v5.h
@@ -455,6 +455,9 @@ enum ap_type {
        AP_TYPE_AHB5H_AP = AP_REG_IDR_VALUE(ARM_ID, AP_REG_IDR_CLASS_MEM_AP, 
8),  /* AHB5 with enhanced HPROT Memory-AP */
 };
 
+extern const struct dap_ops jtag_dp_ops;
+extern const struct dap_ops swd_dap_ops;
+
 /* Check the ap->cfg_reg Long Address field (bit 1)
  *
  * 0b0: The AP only supports physical addresses 32 bits or smaller
diff --git a/src/target/arm_dap.c b/src/target/arm_dap.c
index bc9d962363..84cc6c743b 100644
--- a/src/target/arm_dap.c
+++ b/src/target/arm_dap.c
@@ -20,8 +20,6 @@
 
 static LIST_HEAD(all_dap);
 
-extern const struct dap_ops swd_dap_ops;
-extern const struct dap_ops jtag_dp_ops;
 extern struct adapter_driver *adapter_driver;
 
 /* DAP command support */

-- 

Reply via email to