[PATCH]: 231fdf4bf8 pld: move in pld.h the pld_driver's declaration

[gerrit]

This is an automated email from Gerrit.

"Antonio Borneo <borneo.anto...@gmail.com>" just uploaded a new patch set to 
Gerrit, which you can find at https://review.openocd.org/c/openocd/+/7663

-- gerrit

commit 231fdf4bf8887a0171a596d90c79b112b724e608
Author: Antonio Borneo <borneo.anto...@gmail.com>
Date:   Mon May 1 00:24:37 2023 +0200

    pld: move in pld.h the pld_driver's declaration
    
    The static analyser 'sparse' complains, while compiling a pld
    driver, that the struct pld_driver is declared in the file as
    non static, but it is not exposed through an include file.
    The message is:
            warning: symbol 'XXX' was not declared. Should it be static?
    
    Move the list of pld_driver's declaration in pld.h
    
    Change-Id: I0f917aecc7534c1b51af0afa9b32ccfd33db3511
    Signed-off-by: Antonio Borneo <borneo.anto...@gmail.com>

diff --git a/src/pld/pld.c b/src/pld/pld.c
index dd8f8263fe..7dd2cec18f 100644
--- a/src/pld/pld.c
+++ b/src/pld/pld.c
@@ -16,15 +16,6 @@
 #include <helper/time_support.h>
 
 
-/* pld drivers
- */
-extern struct pld_driver efinix_pld;
-extern struct pld_driver gatemate_pld;
-extern struct pld_driver gowin_pld;
-extern struct pld_driver intel_pld;
-extern struct pld_driver lattice_pld;
-extern struct pld_driver virtex2_pld;
-
 static struct pld_driver *pld_drivers[] = {
        &efinix_pld,
        &gatemate_pld,
diff --git a/src/pld/pld.h b/src/pld/pld.h
index a7cd20f641..322b96ec6e 100644
--- a/src/pld/pld.h
+++ b/src/pld/pld.h
@@ -38,4 +38,11 @@ struct pld_device *get_pld_device_by_num(int num);
 #define ERROR_PLD_DEVICE_INVALID        (-1000)
 #define ERROR_PLD_FILE_LOAD_FAILED      (-1001)
 
+extern struct pld_driver efinix_pld;
+extern struct pld_driver gatemate_pld;
+extern struct pld_driver gowin_pld;
+extern struct pld_driver intel_pld;
+extern struct pld_driver lattice_pld;
+extern struct pld_driver virtex2_pld;
+
 #endif /* OPENOCD_PLD_PLD_H */

--