This is an automated email from Gerrit.

"Antonio Borneo <borneo.anto...@gmail.com>" just uploaded a new patch set to 
Gerrit, which you can find at https://review.openocd.org/c/openocd/+/7660

-- gerrit

commit ce1e3b49344fb4847af3740bb4bd79f002e8bc0d
Author: Antonio Borneo <borneo.anto...@gmail.com>
Date:   Sun Apr 30 23:54:44 2023 +0200

    rtos: move in rtos.h the rtos_type's declaration
    
    The static analyser 'sparse' complains, while compiling a rtos'
    file, that the struct rtos_type is declared in the file as non
    static, but it is not exposed through an include file.
    The message is:
            warning: symbol 'XXX' was not declared. Should it be static?
    
    Move the list of rtos_type's declaration in rtos.h
    
    Change-Id: Ia96dff077407a6653b11920519c1724e4c1167a3
    Signed-off-by: Antonio Borneo <borneo.anto...@gmail.com>

diff --git a/src/rtos/rtos.c b/src/rtos/rtos.c
index f1e8956a38..6c88de33cd 100644
--- a/src/rtos/rtos.c
+++ b/src/rtos/rtos.c
@@ -15,22 +15,6 @@
 #include "helper/binarybuffer.h"
 #include "server/gdb_server.h"
 
-/* RTOSs */
-extern const struct rtos_type freertos_rtos;
-extern const struct rtos_type threadx_rtos;
-extern const struct rtos_type ecos_rtos;
-extern const struct rtos_type linux_rtos;
-extern const struct rtos_type chibios_rtos;
-extern const struct rtos_type chromium_ec_rtos;
-extern const struct rtos_type embkernel_rtos;
-extern const struct rtos_type mqx_rtos;
-extern const struct rtos_type ucos_iii_rtos;
-extern const struct rtos_type nuttx_rtos;
-extern const struct rtos_type hwthread_rtos;
-extern const struct rtos_type riot_rtos;
-extern const struct rtos_type zephyr_rtos;
-extern const struct rtos_type rtkernel_rtos;
-
 static const struct rtos_type *rtos_types[] = {
        &threadx_rtos,
        &freertos_rtos,
diff --git a/src/rtos/rtos.h b/src/rtos/rtos.h
index 9128c163c7..e283dd21b2 100644
--- a/src/rtos/rtos.h
+++ b/src/rtos/rtos.h
@@ -135,4 +135,19 @@ int rtos_read_buffer(struct target *target, target_addr_t 
address,
 int rtos_write_buffer(struct target *target, target_addr_t address,
                uint32_t size, const uint8_t *buffer);
 
+extern const struct rtos_type chibios_rtos;
+extern const struct rtos_type chromium_ec_rtos;
+extern const struct rtos_type ecos_rtos;
+extern const struct rtos_type embkernel_rtos;
+extern const struct rtos_type freertos_rtos;
+extern const struct rtos_type hwthread_rtos;
+extern const struct rtos_type linux_rtos;
+extern const struct rtos_type mqx_rtos;
+extern const struct rtos_type nuttx_rtos;
+extern const struct rtos_type riot_rtos;
+extern const struct rtos_type rtkernel_rtos;
+extern const struct rtos_type threadx_rtos;
+extern const struct rtos_type ucos_iii_rtos;
+extern const struct rtos_type zephyr_rtos;
+
 #endif /* OPENOCD_RTOS_RTOS_H */

-- 

Reply via email to