---
**[tickets:#404] src/jtag/interface.h adapter_driver::reset(int srst, int trst)
args are in wrong order**
**Status:** new
**Milestone:** 0.11.0
**Created:** Wed Jun 28, 2023 08:01 AM UTC by Tommy Murphy
**Last Updated:** Wed Jun 28, 2023 08:01 AM UTC
**Owner:** nobody
`src/jtag/interface.h adapter_driver::reset(int srst, int trst)` args are in
wrong order with respect to how they appear elsewhere in the code and driver
implementations.
See this mailing list thread for more info:
*
https://sourceforge.net/p/openocd/mailman/openocd-user/thread/lo0p265mb6866bd80cfbb5815ed072575f9...@lo0p265mb6866.gbrp265.prod.outlook.com/
In practice this has no functional impact but should probably be fixed to avoid
confusion?
I think that the fix is trivial - change this:
```
* @param srst 1 to assert SRST, 0 to deassert SRST.
* @param trst 1 to assert TRST, 0 to deassert TRST.
* @returns ERROR_OK on success, or an error code on failure.
*/
int (*reset)(int srst, int trst);
```
to this:
```
* @param trst 1 to assert TRST, 0 to deassert TRST.
* @param srst 1 to assert SRST, 0 to deassert SRST.
* @returns ERROR_OK on success, or an error code on failure.
*/
int (*reset)(int trst, int srst);
```
I'm not clear yet if any changes are also needed to the user or developer
documentation or anywhere else?
* https://openocd.org/doc-release/html/index.html
* https://openocd.org/doc-release/doxygen/index.html
---
Sent from sourceforge.net because openocd-devel@lists.sourceforge.net is
subscribed to https://sourceforge.net/p/openocd/tickets/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/openocd/admin/tickets/options. Or, if this is a
mailing list, you can unsubscribe from the mailing list.
