This is an automated email from Gerrit.

"Tim Newsome <t...@sifive.com>" just uploaded a new patch set to Gerrit, which 
you can find at https://review.openocd.org/c/openocd/+/7814

-- gerrit

commit 23acdc9c21ee13cc4ad367998c9e607e7ac4461f
Author: eolson <erin.ol...@seagate.com>
Date:   Thu Jun 22 13:02:21 2023 -0500

    Add null pointer check before right shift for bscan tunneling.
    
    Change-Id: I5d4764c777f33d48705b3e5273eb840c13cfbfb7
    Signed-off-by: eolson <erin.ol...@seagate.com>

diff --git a/src/target/riscv/batch.c b/src/target/riscv/batch.c
index 8ec043efb7..d39967e4df 100644
--- a/src/target/riscv/batch.c
+++ b/src/target/riscv/batch.c
@@ -115,8 +115,10 @@ int riscv_batch_run(struct riscv_batch *batch)
 
        if (bscan_tunnel_ir_width != 0) {
                /* need to right-shift "in" by one bit, because of clock skew 
between BSCAN TAP and DM TAP */
-               for (size_t i = 0; i < batch->used_scans; ++i)
-                       buffer_shr((batch->fields + i)->in_value, 
DMI_SCAN_BUF_SIZE, 1);
+               for (size_t i = 0; i < batch->used_scans; ++i) {
+                       if ((batch->fields + i)->in_value)
+                               buffer_shr((batch->fields + i)->in_value, 
DMI_SCAN_BUF_SIZE, 1);
+               }
        }
 
        for (size_t i = 0; i < batch->used_scans; ++i)

-- 

Reply via email to