[PATCH]: 826d04d330 jtag/drivers/bcm2835gpio: do not configure push-pull inputs as output

[gerrit]

This is an automated email from Gerrit.

"Vincent Fazio <vfa...@gmail.com>" just uploaded a new patch set to Gerrit, 
which you can find at https://review.openocd.org/c/openocd/+/7862

-- gerrit

commit 826d04d330e97a8851dbbc9ddd06f23762372c16
Author: Brandon Pupp <bp...@xes-inc.com>
Date:   Fri Aug 18 09:51:06 2023 -0500

    jtag/drivers/bcm2835gpio: do not configure push-pull inputs as output
    
    Previously, if a pin was configured as ADAPTER_GPIO_INIT_STATE_INPUT and
    its drive value was ADAPTER_GPIO_DRIVE_MODE_PUSH_PULL, initialize_gpio
    would configure the pin as an output.
    
    The set_gpio_value function is optimized to not set the direction for
    pins configured as ADAPTER_GPIO_DRIVE_MODE_PUSH_PULL as it only needs to
    be set once. When initialize_gpio performs this setup, it checked only
    that the drive value was ADAPTER_GPIO_DRIVE_MODE_PUSH_PULL to set the
    output direction but did not exclude input pins which have already had
    their direction set.
    
    Now, input pins are ignored when initialize_gpio checks for
    ADAPTER_GPIO_DRIVE_MODE_PUSH_PULL to set the mode to output.
    
    Change-Id: I4fc7a8132a6b00c7f213ec9fd05c7bbb37ee5f20
    Fixes: 0dd969d83bad ("drivers/bcm2835gpio: Migrate to adapter gpio 
commands")
    Signed-off-by: Brandon Pupp <bp...@xes-inc.com>
    [vfazio: update commit message]
    Signed-off-by: Vincent Fazio <vfa...@xes-inc.com>

diff --git a/src/jtag/drivers/bcm2835gpio.c b/src/jtag/drivers/bcm2835gpio.c
index 39e4af3657..f41f7b51ea 100644
--- a/src/jtag/drivers/bcm2835gpio.c
+++ b/src/jtag/drivers/bcm2835gpio.c
@@ -167,7 +167,8 @@ static void initialize_gpio(enum adapter_gpio_config_index 
idx)
        }
 
        /* Direction for non push-pull is already set by set_gpio_value() */
-       if (adapter_gpio_config[idx].drive == ADAPTER_GPIO_DRIVE_MODE_PUSH_PULL)
+       if (adapter_gpio_config[idx].drive == ADAPTER_GPIO_DRIVE_MODE_PUSH_PULL
+               && adapter_gpio_config[idx].init_state != 
ADAPTER_GPIO_INIT_STATE_INPUT)
                OUT_GPIO(adapter_gpio_config[idx].gpio_num);
        bcm2835_gpio_synchronize();
 }

--