This is an automated email from Gerrit.

"Tomas Vanek <van...@fbl.cz>" just uploaded a new patch set to Gerrit, which 
you can find at https://review.openocd.org/c/openocd/+/7885

-- gerrit

commit 935ea99bd5c69360ed74b7091cd2f4ae881e09c1
Author: Tomas Vanek <van...@fbl.cz>
Date:   Tue Sep 5 18:52:38 2023 +0200

    flash/nor: remove useless bank->next = NULL
    
    struct flash_bank must be zeroed anyway, calloc() is always used.
    
    Signed-off-by: Tomas Vanek <van...@fbl.cz>
    Change-Id: I7ab3b9c66f99688c6095a0a547a05448c9e37d68

diff --git a/src/flash/nor/at91sam7.c b/src/flash/nor/at91sam7.c
index 8bb2994ed1..6879a1bf23 100644
--- a/src/flash/nor/at91sam7.c
+++ b/src/flash/nor/at91sam7.c
@@ -576,7 +576,6 @@ static int at91sam7_read_part_info(struct flash_bank *bank)
                                        return ERROR_FAIL;
                                }
                                fb->name = strdup("sam7_probed");
-                               fb->next = NULL;
 
                                /* link created bank in 'flash_banks' list */
                                t_bank->next = fb;
@@ -765,7 +764,6 @@ FLASH_BANK_COMMAND_HANDLER(at91sam7_flash_bank_command)
                                        return ERROR_FAIL;
                                }
                                fb->name = strdup("sam7_probed");
-                               fb->next = NULL;
 
                                /* link created bank in 'flash_banks' list */
                                t_bank->next = fb;
diff --git a/src/flash/nor/cc26xx.c b/src/flash/nor/cc26xx.c
index 6256ba6e71..54d61421ce 100644
--- a/src/flash/nor/cc26xx.c
+++ b/src/flash/nor/cc26xx.c
@@ -261,7 +261,6 @@ FLASH_BANK_COMMAND_HANDLER(cc26xx_flash_bank_command)
 
        /* Finish initialization of bank */
        bank->driver_priv = cc26xx_bank;
-       bank->next = NULL;
 
        return ERROR_OK;
 }
diff --git a/src/flash/nor/cc3220sf.c b/src/flash/nor/cc3220sf.c
index 432a393f8b..74cb7aea57 100644
--- a/src/flash/nor/cc3220sf.c
+++ b/src/flash/nor/cc3220sf.c
@@ -96,7 +96,6 @@ FLASH_BANK_COMMAND_HANDLER(cc3220sf_flash_bank_command)
 
        /* Finish initialization of flash bank */
        bank->driver_priv = cc3220sf_bank;
-       bank->next = NULL;
 
        return ERROR_OK;
 }
diff --git a/src/flash/nor/npcx.c b/src/flash/nor/npcx.c
index bc84753463..96ed6abb69 100644
--- a/src/flash/nor/npcx.c
+++ b/src/flash/nor/npcx.c
@@ -315,7 +315,6 @@ FLASH_BANK_COMMAND_HANDLER(npcx_flash_bank_command)
 
        /* Finish initialization of bank */
        bank->driver_priv = npcx_bank;
-       bank->next = NULL;
 
        return ERROR_OK;
 }

-- 

Reply via email to