This is an automated email from Gerrit. "Jose Borja Castillo Sanchez <joscas...@uma.es>" just uploaded a new patch set to Gerrit, which you can find at https://review.openocd.org/c/openocd/+/7924
-- gerrit commit cbe7797df4d441bc6db0bd0c028477d07a0cc658 Author: José Borja Castillo <joscas...@uma.es> Date: Mon Oct 2 12:59:57 2023 +0200 jtag/drivers/xvc: XVC support Rebased patch #6867 (add Xilinx XVC TCP) to HEAD, updated to new LICENSE Updated to LICENSE SPDX tags. Change-Id: If7721b3081feffb53490454e1150e4e13f58e8c9 Signed-off-by: José Borja Castillo <joscas...@uma.es> diff --git a/doc/openocd.texi b/doc/openocd.texi index f70b8ba3d0..eb0a72bdbb 100644 --- a/doc/openocd.texi +++ b/doc/openocd.texi @@ -3541,6 +3541,8 @@ Only an USB cable connected to the D+/D- pins is necessary. This driver implements bitbang mode of JTAG devices using Xilinx Virtual Cable messages over TCP/IP. This implementation is XVC protocol 1.0 only, does not support 1.1 extension. +The protocol is described at this link: @url{https://github.com/Xilinx/XilinxVirtualCable} [checked 2/oct/2023]. +Link title: ``XilinxVirtualCable'' Example configuration: @example diff --git a/src/jtag/drivers/xvc.c b/src/jtag/drivers/xvc.c index 2dee51e73f..f62b8802b8 100644 --- a/src/jtag/drivers/xvc.c +++ b/src/jtag/drivers/xvc.c @@ -1,3 +1,5 @@ +// SPDX-License-Identifier: GPL-2.0-or-later + /*************************************************************************** * Copyright (C) 2021 by Jose Borja Castillo, DTE-UMA * * joscas...@uma.es * @@ -6,19 +8,6 @@ * 1.1 extension. * * Some parts of the code are inspired on both bitbang.c and jlink.c * * by Øyvind Harboe and Paul Fertser, respectively. * - * * - * This program is free software; you can redistribute it and/or modify * - * it under the terms of the GNU General Public License as published by * - * the Free Software Foundation; either version 2 of the License, or * - * (at your option) any later version. * - * * - * This program is distributed in the hope that it will be useful, * - * but WITHOUT ANY WARRANTY; without even the implied warranty of * - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * - * GNU General Public License for more details. * - * * - * You should have received a copy of the GNU General Public License * - * along with this program. If not, see <http://www.gnu.org/licenses/>. * ***************************************************************************/ #ifdef HAVE_CONFIG_H @@ -82,7 +71,7 @@ static int xvc_fill_buffer(void); /* Auxiliary and TCL helper functions*/ static unsigned int xvc_bits_to_bytes(unsigned int bits) { - return (bits + 7) / 8; + return DIV_ROUND_UP(bits, 8); } static int xvc_speed(int speed) @@ -428,7 +417,7 @@ static const struct command_registration xvc_command_handlers[] = { .name = "xvc_host", .handler = xvc_handle_host_command, .mode = COMMAND_CONFIG, - .help = "Set the host to use to connect to the remote XVC server.\n", + .help = "Set the host to use to connect to the remote XVC server.", .usage = "host_name", }, COMMAND_REGISTRATION_DONE diff --git a/src/jtag/interface.h b/src/jtag/interface.h index 3df424086d..75e5355a70 100644 --- a/src/jtag/interface.h +++ b/src/jtag/interface.h @@ -401,5 +401,6 @@ extern struct adapter_driver vdebug_adapter_driver; extern struct adapter_driver vsllink_adapter_driver; extern struct adapter_driver xds110_adapter_driver; extern struct adapter_driver xlnx_pcie_xvc_adapter_driver; +extern struct adapter_driver xvc_driver; #endif /* OPENOCD_JTAG_INTERFACE_H */ --