This is an automated email from Gerrit.

"Walter J. <walter...@oss.cipunited.com>" just uploaded a new patch set to 
Gerrit, which you can find at https://review.openocd.org/c/openocd/+/7932

-- gerrit

commit 10d36310fa5f68945d41e83a25fffe3eed71ab5f
Author: Walter Ji <walter...@oss.cipunited.com>
Date:   Mon Oct 9 11:42:44 2023 +0800

    target/mips32: check read regs result in save context
    
    Add result check for mips32_pracc_read_regs in mips32_save_context.
    
    Change-Id: Ie796d2b05a9feb11e246c2d0771b52cad4fb70db
    Signed-off-by: Walter Ji <walter...@oss.cipunited.com>

diff --git a/src/target/mips32.c b/src/target/mips32.c
index 18160b2373..99688b0080 100644
--- a/src/target/mips32.c
+++ b/src/target/mips32.c
@@ -306,7 +306,11 @@ int mips32_save_context(struct target *target)
        struct mips32_common *mips32 = target_to_mips32(target);
 
        /* read core registers */
-       mips32_pracc_read_regs(mips32);
+       int retval = mips32_pracc_read_regs(mips32);
+       if (retval != ERROR_OK) {
+               LOG_ERROR("Could not read core registers from target");
+               return retval;
+       }
 
        for (i = 0; i < MIPS32_NUM_REGS; i++) {
                if (!mips32->core_cache->reg_list[i].valid)

-- 

Reply via email to