[PATCH]: e39ee7f0e7 helper/command: simplify script_command_args_alloc()

[gerrit]

This is an automated email from Gerrit.

"Antonio Borneo <borneo.anto...@gmail.com>" just uploaded a new patch set to 
Gerrit, which you can find at https://review.openocd.org/c/openocd/+/8054

-- gerrit

commit e39ee7f0e70f40f0dd8824fb302f5a15c723b7e2
Author: Antonio Borneo <antonio.bor...@foss.st.com>
Date:   Sun Aug 6 10:32:46 2023 +0200

    helper/command: simplify script_command_args_alloc()
    
    The output parameter nwords is always equal to the input paramater
    argc, when the function succeeds.
    
    Drop the parameter nwords and let the caller use directly the
    value in argc.
    
    While there, convert some 'unsigned' to 'unsigned int'.
    
    Change-Id: Ie3d8ce1351792f3c07fe39cdcbcd180fd24dc928
    Signed-off-by: Antonio Borneo <antonio.bor...@foss.st.com>

diff --git a/src/helper/command.c b/src/helper/command.c
index 96023336c9..f7ec0e21fa 100644
--- a/src/helper/command.c
+++ b/src/helper/command.c
@@ -161,15 +161,13 @@ static void script_command_args_free(char **words, 
unsigned nwords)
        free(words);
 }
 
-static char **script_command_args_alloc(
-       unsigned argc, Jim_Obj * const *argv, unsigned *nwords)
+static char **script_command_args_alloc(unsigned int argc, Jim_Obj * const 
*argv)
 {
        char **words = malloc(argc * sizeof(char *));
        if (!words)
                return NULL;
 
-       unsigned i;
-       for (i = 0; i < argc; i++) {
+       for (unsigned int i = 0; i < argc; i++) {
                const char *w = Jim_GetString(argv[i], NULL);
                words[i] = strdup(w);
                if (!words[i]) {
@@ -177,7 +175,6 @@ static char **script_command_args_alloc(
                        return NULL;
                }
        }
-       *nwords = i;
        return words;
 }
 
@@ -901,8 +898,8 @@ static int exec_command(Jim_Interp *interp, struct 
command_context *cmd_ctx,
                return c->jim_handler(interp, argc, argv);
 
        /* use c->handler */
-       unsigned int nwords;
-       char **words = script_command_args_alloc(argc, argv, &nwords);
+       unsigned int nwords = argc;
+       char **words = script_command_args_alloc(argc, argv);
        if (!words)
                return JIM_ERR;
 

--