This is an automated email from Gerrit.

"Evgeniy Naydanov <evgeniy.nayda...@syntacore.com>" just uploaded a new patch 
set to Gerrit, which you can find at https://review.openocd.org/c/openocd/+/8061

-- gerrit

commit db588d06dc537fcf3df4fac21a7eb96215a5c84c
Author: Evgeniy Naydanov <evgeniy.nayda...@syntacore.com>
Date:   Mon Dec 25 13:03:54 2023 +0300

    doc: `address` is optional in `*_image` commands
    
    Change-Id: I3d4320634bf59be18bbcb22c9e4b13a3ccd7a45a
    Signed-off-by: Evgeniy Naydanov <evgeniy.nayda...@syntacore.com>

diff --git a/doc/openocd.texi b/doc/openocd.texi
index ec7c9964a8..b83a6f2f72 100644
--- a/doc/openocd.texi
+++ b/doc/openocd.texi
@@ -9325,7 +9325,7 @@ Loads an image stored in memory by 
@command{fast_load_image} to the
 current target. Must be preceded by fast_load_image.
 @end deffn
 
-@deffn {Command} {fast_load_image} filename address 
[@option{bin}|@option{ihex}|@option{elf}|@option{s19}]
+@deffn {Command} {fast_load_image} filename [address 
[@option{bin}|@option{ihex}|@option{elf}|@option{s19} [@option{min_addr} 
[@option{max_length}]]]]]]
 Normally you should be using @command{load_image} or GDB load. However, for
 testing purposes or when I/O overhead is significant(OpenOCD running on an 
embedded
 host), storing the image in memory and uploading the image to the target
@@ -9336,7 +9336,7 @@ target programming performance as I/O and target 
programming can easily be profi
 separately.
 @end deffn
 
-@deffn {Command} {load_image} filename address 
[[@option{bin}|@option{ihex}|@option{elf}|@option{s19}] @option{min_addr} 
@option{max_length}]
+@deffn {Command} {load_image} filename [address 
[@option{bin}|@option{ihex}|@option{elf}|@option{s19} [@option{min_addr} 
[@option{max_length}]]]]
 Load image from file @var{filename} to target memory offset by @var{address} 
from its load address.
 The file format may optionally be specified
 (@option{bin}, @option{ihex}, @option{elf}, or @option{s19}).
@@ -9361,14 +9361,14 @@ The file format may optionally be specified
 (@option{bin}, @option{ihex}, or @option{elf})
 @end deffn
 
-@deffn {Command} {verify_image} filename address 
[@option{bin}|@option{ihex}|@option{elf}]
+@deffn {Command} {verify_image} filename [address 
[@option{bin}|@option{ihex}|@option{elf}]]
 Verify @var{filename} against target memory starting at @var{address}.
 The file format may optionally be specified
 (@option{bin}, @option{ihex}, or @option{elf})
 This will first attempt a comparison using a CRC checksum, if this fails it 
will try a binary compare.
 @end deffn
 
-@deffn {Command} {verify_image_checksum} filename address 
[@option{bin}|@option{ihex}|@option{elf}]
+@deffn {Command} {verify_image_checksum} filename [address 
[@option{bin}|@option{ihex}|@option{elf}]]
 Verify @var{filename} against target memory starting at @var{address}.
 The file format may optionally be specified
 (@option{bin}, @option{ihex}, or @option{elf})
diff --git a/src/target/target.c b/src/target/target.c
index 5605d29202..61890aa3e5 100644
--- a/src/target/target.c
+++ b/src/target/target.c
@@ -6926,8 +6926,8 @@ static const struct command_registration 
target_exec_command_handlers[] = {
                .mode = COMMAND_ANY,
                .help = "Load image into server memory for later use by "
                        "fast_load; primarily for profiling",
-               .usage = "filename address ['bin'|'ihex'|'elf'|'s19'] "
-                       "[min_address [max_length]]",
+               .usage = "filename [address ['bin'|'ihex'|'elf'|'s19' "
+                       "[min_address [max_length]]]]",
        },
        {
                .name = "fast_load",
@@ -7100,8 +7100,8 @@ static const struct command_registration 
target_exec_command_handlers[] = {
                .name = "load_image",
                .handler = handle_load_image_command,
                .mode = COMMAND_EXEC,
-               .usage = "filename address ['bin'|'ihex'|'elf'|'s19'] "
-                       "[min_address] [max_length]",
+               .usage = "filename [address ['bin'|'ihex'|'elf'|'s19' "
+                       "[min_address [max_length]]]]",
        },
        {
                .name = "dump_image",

-- 

Reply via email to