This is an automated email from Gerrit.
"Antonio Borneo <borneo.anto...@gmail.com>" just uploaded a new patch set to
Gerrit, which you can find at https://review.openocd.org/c/openocd/+/8065
-- gerrit
commit 8da8e478aeadf9e91e980a88dfb9787f90a91b21
Author: Antonio Borneo <borneo.anto...@gmail.com>
Date: Sat Jan 6 17:54:24 2024 +0100
target/mips32: fix false positive from clang
clang build triggers an error for an uninitialized value of the
variable 'instr'.
This is a false positive, as the macro
#define MIPS32_CONFIG3_ISA_MASK (3 << MIPS32_CONFIG3_ISA_SHIFT)
guarantees the switch/case already covers all the possible values
with cases 0, 1, 2 and 3.
Silent clang by adding a useless default case to the switch.
While there, fix the indentation of the switch/case accordingly to
OpenOCD coding style.
Change-Id: I0ae316754ce7d091dd8366bf314b8e6ee780e313
Signed-off-by: Antonio Borneo <borneo.anto...@gmail.com>
diff --git a/src/target/mips32.c b/src/target/mips32.c
index 8a3ddbf0b7..5b94e6c894 100644
--- a/src/target/mips32.c
+++ b/src/target/mips32.c
@@ -1607,17 +1607,18 @@ COMMAND_HANDLER(mips32_handle_cpuinfo_command)
char *instr;
switch ((config3 & MIPS32_CONFIG3_ISA_MASK) >>
MIPS32_CONFIG3_ISA_SHIFT) {
- case 0:
- instr = "MIPS32";
+ case 0:
+ instr = "MIPS32";
break;
- case 1:
- instr = "microMIPS";
+ case 1:
+ instr = "microMIPS";
break;
- case 2:
- instr = "MIPS32 (at reset) and microMIPS";
+ case 2:
+ instr = "MIPS32 (at reset) and microMIPS";
break;
- case 3:
- instr = "microMIPS (at reset) and MIPS32";
+ case 3:
+ default:
+ instr = "microMIPS (at reset) and MIPS32";
break;
}
--
