This is an automated email from Gerrit.

"Antonio Borneo <borneo.anto...@gmail.com>" just uploaded a new patch set to 
Gerrit, which you can find at https://review.openocd.org/c/openocd/+/8206

-- gerrit

commit 86036f439052e58a0f5c24be79cc51956fd2bc0f
Author: Antonio Borneo <borneo.anto...@gmail.com>
Date:   Sun Apr 7 18:32:45 2024 +0200

    jtag: linuxgpiod: use libgpiod v2 API to set gpio active_low
    
    Define and use dummy functions from v2 for v1:
    - gpiod_line_settings_set_active_low().
    
    Change-Id: I2c00e1a71950215c47dc07d71af4f319434a266a
    Signed-off-by: Antonio Borneo <borneo.anto...@gmail.com>

diff --git a/src/jtag/drivers/linuxgpiod.c b/src/jtag/drivers/linuxgpiod.c
index 96d915e291..21983c97ea 100644
--- a/src/jtag/drivers/linuxgpiod.c
+++ b/src/jtag/drivers/linuxgpiod.c
@@ -46,6 +46,7 @@ struct gpiod_line_settings {
        int value;
        int drive;
        int bias;
+       int active_low;
 };
 
 static struct gpiod_line_settings *gpiod_line_settings_new(void)
@@ -97,6 +98,13 @@ static int gpiod_line_settings_set_drive(struct 
gpiod_line_settings *settings, i
        return 0;
 }
 
+static void gpiod_line_settings_set_active_low(struct gpiod_line_settings 
*settings,
+       bool active_low)
+{
+       if (active_low)
+               settings->active_low = GPIOD_LINE_REQUEST_FLAG_ACTIVE_LOW;
+}
+
 static void gpiod_request_config_set_consumer(struct gpiod_request_config 
*config,
        const char *consumer)
 {
@@ -455,11 +463,10 @@ static int helper_get_line(enum adapter_gpio_config_index 
idx)
                break;
        }
 
-       if (adapter_gpio_config[idx].active_low)
-               flags |= GPIOD_LINE_REQUEST_FLAG_ACTIVE_LOW;
+       gpiod_line_settings_set_active_low(line_settings, 
adapter_gpio_config[idx].active_low);
 
        req_cfg->request_type = line_settings->direction;
-       req_cfg->flags = flags | line_settings->drive | line_settings->bias;
+       req_cfg->flags = flags | line_settings->drive | line_settings->bias | 
line_settings->active_low;
 
        retval = gpiod_line_request(gpiod_line[idx], req_cfg, 
line_settings->value);
        if (retval < 0) {

-- 

Reply via email to