[PATCH]: 4fdc8f8cc3 smp: fix SIGSEGV for "smp off" during target examine

[gerrit]

This is an automated email from Gerrit.

"Antonio Borneo <borneo.anto...@gmail.com>" just uploaded a new patch set to 
Gerrit, which you can find at https://review.openocd.org/c/openocd/+/8216

-- gerrit

commit 4fdc8f8cc397ffee850a634833c41787443c5810
Author: Antonio Borneo <borneo.anto...@gmail.com>
Date:   Mon Apr 15 17:42:12 2024 +0200

    smp: fix SIGSEGV for "smp off" during target examine
    
    The gdb subsystem is initialized after the first target examine,
    so the field struct target::gdb_service is NULL during examine.
    
    A command "smp off" in the examine event handler causes a SIGSEGV
    during OpenOCD startup.
    
    Check for pointer not NULL before dereferencing it.
    
    Change-Id: Id115e28be23a957fef1b97ab66d7273f0ea0dce4
    Signed-off-by: Antonio Borneo <borneo.anto...@gmail.com>

diff --git a/src/target/smp.c b/src/target/smp.c
index 50b19d01a0..41ca880d43 100644
--- a/src/target/smp.c
+++ b/src/target/smp.c
@@ -119,7 +119,7 @@ COMMAND_HANDLER(default_handle_smp_command)
                        head->target->smp = 0;
 
                /* fixes the target display to the debugger */
-               if (!list_empty(target->smp_targets))
+               if (!list_empty(target->smp_targets) && target->gdb_service)
                        target->gdb_service->target = target;
 
                return ERROR_OK;

--