[PATCH]: d968fb7202 gdb_server: do not start multiple instances on "pipe"

[gerrit]

This is an automated email from Gerrit.

"Paul Fertser <fercer...@gmail.com>" just uploaded a new patch set to Gerrit, 
which you can find at https://review.openocd.org/c/openocd/+/8222

-- gerrit

commit d968fb720236925f3f0e7cb1900b9ec10ea63aae
Author: Paul Fertser <fercer...@gmail.com>
Date:   Thu Apr 25 14:33:07 2024 +0300

    gdb_server: do not start multiple instances on "pipe"
    
    For configurations which include multiple targets and the "pipe" mode is
    requested only the first gdb_server instance should be enabled,
    otherwise GDB gets confusing replies, goes out of sync and the session
    fails in weird ways.
    
    Compile-tested only.
    
    Signed-off-by: Paul Fertser <fercer...@gmail.com>
    Change-Id: If8f13aa7b58e9b0dc6d5ae88cf75538b34cc1218

diff --git a/src/server/gdb_server.c b/src/server/gdb_server.c
index c1ee4aa2a1..08bf190416 100644
--- a/src/server/gdb_server.c
+++ b/src/server/gdb_server.c
@@ -3871,7 +3871,7 @@ static int gdb_target_add_one(struct target *target)
                return gdb_target_start(target, target->gdb_port_override);
        }
 
-       if (strcmp(gdb_port, "disabled") == 0) {
+       if (strcmp(gdb_port_next, "disabled") == 0) {
                LOG_INFO("gdb port disabled");
                return ERROR_OK;
        }
@@ -3900,6 +3900,8 @@ static int gdb_target_add_one(struct target *target)
                                        gdb_port_next = strdup("0");
                                }
                        }
+               } else if (strcmp(gdb_port_next, "pipe") == 0) {
+                       gdb_port_next = "disabled";
                }
        }
        return retval;

--